Skip Menu |

This queue is for tickets about the CGI-Session CPAN distribution.

Report information
The Basics
Id: 21779
Status: resolved
Priority: 0/
Queue: CGI-Session

People
Owner: Nobody in particular
Requestors: fenlisesi [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 4.13
Fixed in: (no value)



Subject: minor change to import.
I would like to suggest a patch like the following, in case -ip_match is not the last arg to the use statement: --- Session-original.pm 2006-04-12 19:59:41.000000000 +0300 +++ Session-edited.pm 2006-09-29 20:05:53.000000000 +0300 @@ -17,11 +17,16 @@ sub STATUS_EXPIRED () { 8 } # denotes session that was expired. sub import { - my $class = shift; - @_ or return; + my ($class, @args) = @_; + + return unless @args; - for(@_) { - $CGI::Session::IP_MATCH = ( $_ eq '-ip_match' ); + ARG: + foreach my $arg (@args) { + if ($arg eq '-ip_match') { + $CGI::Session::IP_MATCH = 1; + last ARG; + } } } -------------------------------------- $CGI::Session::VERSION = '4.13'; This is perl, v5.8.8 built for i686-linux-thread-multi Linux version 2.6.11.4-21.14-default (geeko@buildhost) (gcc version 3.3.5 20050117 (prerelease) (SUSE Linux)) #1 Thu Aug 24 09:51:41 UTC 2006 Thanks for all the good stuff.
Subject: Re: [rt.cpan.org #21779] minor change to import.
Date: Fri, 29 Sep 2006 13:27:59 -0400
To: bug-CGI-Session [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Show quoted text
> > I would like to suggest a patch like the following, in case -ip_match is > not the last arg to the use statement:
Thanks. This has been applied in our source control system. Mark