| Subject: | Bug when viewing "copied from" revision |
| Date: | Fri, 22 Sep 2006 10:49:19 -0500 |
| To: | bug-SVN-Web [...] rt.cpan.org |
| From: | "Brian Smith" <bsmith94 [...] alumni.utexas.net> |
Message body is not shown because sender requested not to inline it.
Hello,
I discovered a bug in SVN::Web 0.48 that resulted in the script generating
invalid links to files. The problem was due to two, sequential '/'
characters in the generated URL to view the revision from which a file was
copied.
To recreate:
1) View the reivision log for a file that was svn copied from another
revision.
2) Click on the link that reads "Copied from /thepath:therevision".
3) The page that comes up will not have a proper style. Notice that the URL
for the page has //?rev= in it.
4) Click on a link to one of the entries in the revision.
5) You should see a page with the message: Filesystem has no item: File not
found: revision 22, path
'/vendor/SVN-Web/0.48/3rdParty/view/vendor/SVN-Web/0.48/README' at
/usr/lib/perl5/site_perl/5.8.6/SVN/Web/action.pm line 230
The attached diff corrects the generation of the superfluous / character in
the URL, which corrects the problem.
-brian