Bug #21613 for Win32-IPConfig: Requirement of having WRITE access to HKLM is not needed?

Fri Sep 22 08:48:27 2006 santtu [...] iki.fi - Ticket created

Subject:

Requirement of having WRITE access to HKLM is not needed?

Documentation says: "For this module to retrieve information from a host machine, you must have read and write access to the registry on that machine." However, if I change KEY_READ|KEY_WRITE from IPConfig::new to KEY_READ only I still get adapter information etc. read correctly. Using KEY_WRITE actually means that if you have a restricted account (domain user, for example) then Win32::IPConfig *will not work*. I used KEY_READ only and could retrieve adapter information using a domain account, whereas with the original KEY_READ|KEY_WRITE it doesn't work. So is there a particular reason to have KEY_WRITE? After all, IPConfig only reads the registry, and doesn't write to it.. Bug: Win32::IPConfig doesn't work for (a typical, restricted) domain user although HKLM is readable.

Thu Oct 05 15:40:00 2006 jmacfarla [...] cpan.org - Status changed from 'new' to 'open'

Thu Oct 05 15:40:01 2006 jmacfarla [...] cpan.org - Broken in 0.03 added

Thu Oct 05 15:40:01 2006 jmacfarla [...] cpan.org - Broken in 0.04 added

Thu Oct 05 15:40:01 2006 jmacfarla [...] cpan.org - Broken in 0.05 added

Thu Oct 05 15:40:01 2006 jmacfarla [...] cpan.org - Broken in 0.06 added

Thu Oct 05 15:40:01 2006 jmacfarla [...] cpan.org - Broken in 0.07 added

Thu Oct 05 15:40:01 2006 jmacfarla [...] cpan.org - Broken in 0.08 added

Thu Oct 05 15:51:42 2006 jmacfarla [...] cpan.org - Correspondence added

Show quoted text

> "For this module to retrieve information from a host machine, you must > have read and write access to the registry on that machine." > > However, if I change KEY_READ|KEY_WRITE from IPConfig::new to KEY_READ > only I still get adapter information etc. read correctly. > > Using KEY_WRITE actually means that if you have a restricted account > (domain user, for example) then Win32::IPConfig *will not work*. I used > KEY_READ only and could retrieve adapter information using a domain > account, whereas with the original KEY_READ|KEY_WRITE it doesn't work. > > So is there a particular reason to have KEY_WRITE? After all, IPConfig > only reads the registry, and doesn't write to it..

Actually, it has had needed to write to the registry since 0.03. The set_* methods require this. Show quoted text

> Bug: Win32::IPConfig doesn't work for (a typical, restricted) domain > user although HKLM is readable.

I agree this is a reasonable request and will look at incorporating this into the next release, after I've looked at how best to retain read/write functionality for the set_* methods.

Mon Jun 14 12:34:32 2010 alabamapaul [...] gmail.com - Correspondence added

From:

alabamapaul [...] gmail.com

You could add an optional second parameter to new() that would be a "read_only" flag. For backward compatibility, you can default the flag to 0. The attached patches provide this read_only support.

Subject:

Adapter.patch

609a610,612 > ## Error, if read only flag is set > croak "Marked as read only, settings cannot be changed" if $self->{"read_only"}; > 627a631,633 > > ## Error, if read only flag is set > croak "Marked as read only, settings cannot be changed" if $self->{"read_only"}; 649a656,658 > ## Error, if read only flag is set > croak "Marked as read only, settings cannot be changed" if $self->{"read_only"}; >

Subject:

IPConfig.patch

18c18,21 < --- > > my $read_only = shift; > $read_only = 0 if (!defined($read_only)); > 20c23 < {Access => KEY_READ | KEY_WRITE}) --- > {Access => (($read_only) ? (KEY_READ) : (KEY_READ | KEY_WRITE))}) 29a33 > $self->{"read_only"} = $read_only; 370c374 < =item $ipconfig = Win32::IPConfig->new($host); --- > =item $ipconfig = Win32::IPConfig->new($host, $read_only); 373a378,379 > $read_only indicates the object will be used to examine current > settings and will not be allowed to make changes.

Mon Jul 26 16:59:58 2010 jmacfarla [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Jul 26 16:59:59 2010 jmacfarla [...] cpan.org - Fixed in 0.10 added