Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 21607
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: chris+rt [...] chrisdolan.net
Requestors: adamk [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.2
Fixed in: (no value)



Subject: 0.2 fails to install with PPI 1.118
1.118 is ready to release, I tried installing it and then installing 0.20 on top of it, and I'm seeing various failures. Filing this as a bug here, so that you can fix it and notify me you've done so (so I can release 1.118) in one simple process.
Subject: Re: [rt.cpan.org #21607] 0.2 fails to install with PPI 1.118
Date: Fri, 22 Sep 2006 00:15:33 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] chrisdolan.net>
On Sep 21, 2006, at 11:27 PM, via RT wrote: Show quoted text
> Fri Sep 22 00:27:41 2006: Request 21607 was acted upon. > Transaction: Ticket created by ADAMK > Queue: Perl-Critic > Subject: 0.2 fails to install with PPI 1.118 > Broken in: 0.2 > Severity: Critical > Owner: Nobody > Requestors: ADAMK@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=21607 > > > > 1.118 is ready to release, I tried installing it and then installing > 0.20 on top of it, and I'm seeing various failures. > > Filing this as a bug here, so that you can fix it and notify me you've > done so (so I can release 1.118) in one simple process.
Fixed. It appears it due to was a thinko in PPI::Statement::Include. The following patch fixes it. I will commit that patch to the PPI SVN shortly. --- lib/PPI/Statement/Include.pm (revision 1068) +++ lib/PPI/Statement/Include.pm (working copy) @@ -128,7 +128,7 @@ sub pragma { my $self = shift; my $module = $self->module or return ''; - $module =~ /^[a-z]$/ ? $module : ''; + $module =~ /^[a-z]+$/ ? $module : ''; } =pod Chris -- Chris Dolan, Software Developer, http://www.chrisdolan.net/ Public key: http://www.chrisdolan.net/public.key vCard: http://www.chrisdolan.net/ChrisDolan.vcf