Bug #21532 for ExtUtils-MakeMaker: Silence warnings on developer releases with $VERSION = eval $VERSION

Sun Sep 17 01:02:42 2006 ANDK [...] cpan.org - Ticket created

Subject:

Silence warnings on developer releases with $VERSION = eval $VERSION

MakeMaker should adopt the practice to eval its own version to get rid of underscores in developer versions. Underscore in version number leads to useless and annoying warnings. Untested patch follows --- /tmp/MakeMaker.pm~ 2006-09-17 07:00:15.000000000 +0200 +++ /tmp/MakeMaker.pm 2006-09-17 07:00:15.000000000 +0200 @@ -22,6 +22,7 @@ use strict; $VERSION = '6.30_04'; +$VERSION = eval $VERSION; ($Revision) = q$Revision: 18035 $ =~ /Revision:\s+(\S+)/; @ISA = qw(Exporter);

Fri Sep 11 09:53:44 2009 jdhedden [...] cpan.org - Correspondence added

Subject:

[PATCH] Silence warnings on developer releases with $VERSION = eval $VERSION

I have submitted a patch for this against 'blead', and have attached it here as well. See my posting here for more details: http://www.nntp.perl.org/group/perl.perl5.porters/2009/09/msg150830.html On Sun Sep 17 01:02:42 2006, ANDK wrote: Show quoted text

> MakeMaker should adopt the practice to eval its own version to get rid > of underscores in developer versions. Underscore in version number leads > to useless and annoying warnings. > > Untested patch follows > > --- /tmp/MakeMaker.pm~ 2006-09-17 07:00:15.000000000 +0200 > +++ /tmp/MakeMaker.pm 2006-09-17 07:00:15.000000000 +0200 > @@ -22,6 +22,7 @@ > use strict; > > $VERSION = '6.30_04'; > +$VERSION = eval $VERSION; > ($Revision) = q$Revision: 18035 $ =~ /Revision:\s+(\S+)/; > > @ISA = qw(Exporter);

From 0718fab61774c8b2be32f7ba4e84874a4183a2b0 Mon Sep 17 00:00:00 2001 From: Jerry D. Hedden <jdhedden@cpan.org> Date: Thu, 10 Sep 2009 14:24:04 -0400 Subject: [PATCH] Eval $ExtUtils::MakeMaker::VERSION to make it numeric --- ext/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ext/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm b/ext/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm index 893c0bf..3e37f06 100644 --- a/ext/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm +++ b/ext/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm @@ -18,11 +18,11 @@ our @Overridable; my @Prepend_parent; my %Recognized_Att_Keys; -our $VERSION = '6.55_02'; +our $VERSION = '6.55_03'; +$VERSION = eval $VERSION; # Emulate something resembling CVS $Revision$ -(our $Revision = $VERSION) =~ s{_}{}; -$Revision = int $Revision * 10000; +our $Revision = $VERSION * 10000; our $Filename = __FILE__; # referenced outside MakeMaker -- 1.6.1.2

Fri Sep 11 09:53:45 2009 The RT System itself - Status changed from 'new' to 'open'

Fri Sep 11 09:54:08 2009 jdhedden [...] cpan.org - Severity Wishlist changed to Normal

Fri Sep 11 09:54:08 2009 jdhedden [...] cpan.org - Broken in 6.55_02 added

Fri Sep 11 23:29:31 2009 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #21532] [PATCH] Silence warnings on developer releases with $VERSION = eval $VERSION
Date:	Fri, 11 Sep 2009 20:29:10 -0700
To:	bug-ExtUtils-MakeMaker [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

Jerry D. Hedden via RT wrote: Show quoted text

> I have submitted a patch for this against 'blead', and have attached it > here as well. See my posting here for more details:

I feel like I did this at some point but it caused a problem. It was related to the fact that doing this loses the underscore in $VERSION and ExtUtils::MakeMaker->VERSION giving it a different outcome than parse_version(). -- 10. Not allowed to purchase anyone's soul on government time. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/

Fri Sep 18 11:38:50 2009 jdhedden [...] cpan.org - Correspondence added

Show quoted text

> I feel like I did this at some point but it caused a problem. It was > related > to the fact that doing this loses the underscore in $VERSION and > ExtUtils::MakeMaker->VERSION giving it a different outcome than > parse_version().

Yes, it does: MM->parse_version gives 6.55_02 and ->VERSION gives 6.5502. The question then becomes, how does this cause any problems? parse_version is for MakeMaker's use and making distributions. $VERSION is for programmatic use for version comparisons. I can't think how this would cause any conflicts. Also, looking through all the versions in the archive from 5.47_01 onward, I could not find a version of MakeMaker.pm that had an 'eval $VERSION' in it. So if you did try this, it wasn't in a version placed on CPAN.

Fri Mar 05 20:04:48 2010 jkeen [...] verizon.net - Correspondence added

From:

jkeen [...] verizon.net

The following IRC #corehackers exchange may pertain to the issues discussed in this RT: Show quoted text

kid51> Suppose that when I say 'perldoc -m ExtUtils::MakeMaker', I see:

our $VERSION = '6.55_02'; Show quoted text

kid51> Suppose then that in a Makefile.PL where I want 'BUILD_REQUIRES'

-- which was introduced in 6.55_02 -- I then say: use ExtUtils::MakeMaker 6.55_02; Show quoted text

kid51> ... why do I get this response: kid51> $ perl Makefile.PL kid51> ExtUtils::MakeMaker version 6.5502 required--this is only

version 6.55_02 at Makefile.PL line 2. Show quoted text

kid51> BEGIN failed--compilation aborted at Makefile.PL line 2.

... Show quoted text

mst> kid51: because MakeMaker was missing the $VERSION = eval

$VERSION; line For what I need to do, BUILD_REQUIRES is precisely the feature that I need, because I only need a particular (recent version of) a particular distribution for tests. Thank you very much. Jim Keenan

Thu Jul 18 16:06:35 2013 BINGOS [...] cpan.org - Correspondence added 5 min

This was resolved with dev release 6.57_07 Many thanks.

Thu Jul 18 16:06:37 2013 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jul 18 16:06:37 2013 BINGOS [...] cpan.org - Fixed in 6.57_07 added