Skip Menu |

This queue is for tickets about the MP3-Info CPAN distribution.

Report information
The Basics
Id: 2143
Status: resolved
Priority: 0/
Queue: MP3-Info
People
Owner: cnandor [...] cpan.org
Requestors: tim [...] tim-landscheidt.de
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.01
Fixed in: 1.02

History Show all quoted text
  Sat Feb 22 10:22:10 2003 Guest - Ticket created
Subject: "Unitialized" issue with get_mp3tag(), use_mp3_utf8(1) and unset genre
I keep "catagorizing" my MP3s with no genre (''), which set_mp3tag() maps to 0xFF. Read by get_mp3tag(), these give an undefined value for $info{'GENRE'} at first. With use_mp3_utf8(1) && "perl -w", then get_mp3tag() chokes at line #453 passing this undefined value to Unicode::String::latin1() yielding a warning. Proposed solutions: 1. add a genre '' with 0xFF as the array index; 2. insert test at line #451 setting $info{'GENRE'} to '' if it is undefined; 3. rewrite the loop at line #452: if the current value is undefined: a) "next"; b) set the value to '' (hack: "Unicode::String::latin1($info{$key} || '')") As I never had a big demand for genres, I'd prefer solution 3. a) but I cannot estimate the implications for the rest of the code. I will probably report another Unicode bug around line #496 later today. (Unicode ist really great - just the transitions *suck*.)
  Sat Feb 22 11:54:11 2003 cnandor [...] cpan.org - Taken
  Sat Feb 22 14:02:47 2003 cnandor [...] cpan.org - Status changed from 'new' to 'open'
  Sat Feb 22 14:04:59 2003 cnandor [...] cpan.org - Correspondence added
Thanks. In fact, in my working copy, I already had "next unless $info{$key}", which appears to be your suggestion as well. Great minds, yadda yadda. :) Looking forward to the next bug report ...
  Sun Feb 23 05:22:20 2003 Guest - Correspondence added
From: tim [...] tim-landscheidt.de
That's great! :-) Regarding the other bug report: I cannot rule out that the "bug" was triggered by a corrupt ID3v2 tag. I'll keep my eyes open, but won't investigate this matter any further without a definite need to do so :-).
  Sun Feb 23 08:34:35 2003 pudge [...] pobox.com - Correspondence added
Date: Sun, 23 Feb 2003 08:33:33 -0500
To: bug-MP3-Info [...] rt.cpan.org
From: Chris Nandor <pudge [...] pobox.com>
Subject: Re: [cpan #2143] "Unitialized" issue with get_mp3tag(), use_mp3_utf8(1) and unset genre
RT-Send-Cc:
Show quoted text
>That's great! :-) Regarding the other bug report: I cannot rule out >that the "bug" was triggered by a corrupt ID3v2 tag. I'll keep my eyes >open, but won't investigate this matter any further without a definite >need to do so :-).
If you think you have a bad tag, please put it up for me somewhere, or maybe try attaching it to the bug report, and I can take a look. Thanks, -- Chris Nandor pudge@pobox.com http://pudge.net/ Open Source Development Network pudge@osdn.com http://osdn.com/
  Mon Mar 03 08:48:06 2003 cnandor [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Mar 03 08:48:06 2003 cnandor [...] cpan.org - Fixed in 1.02 added
  Mon Mar 03 08:48:07 2003 The RT System itself - Status changed from 'resolved' to 'open'
  Mon Mar 03 08:48:07 2003 cnandor [...] cpan.org - Correspondence added
Subject: Fixed
Bug is fixed, and included in v1.02. Thanks.
  Mon Mar 03 08:48:17 2003 cnandor [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Mar 04 20:13:37 2003 Guest - Correspondence added
From: Tim Landscheidt <tim [...] tim-landscheidt.de>
Show quoted text
> [...] > If you think you have a bad tag, please put it up for me somewhere,
or Show quoted text
> maybe try attaching it to the bug report, and I can take a look.
Thanks, I didn't keep the file in its original state :-(. BTW, scfc* is just another account of me.
  Tue Mar 04 20:13:38 2003 The RT System itself - Status changed from 'resolved' to 'open'
  Tue Mar 04 20:15:43 2003 cnandor [...] cpan.org - Status changed from 'open' to 'resolved'