Skip Menu |

This queue is for tickets about the HTML-CalendarMonth CPAN distribution.

Report information
The Basics
Id: 21397
Status: resolved
Priority: 0/
Queue: HTML-CalendarMonth

People
Owner: MSISK [...] cpan.org
Requestors: jamie [...] mccarthy.vg
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.18
Fixed in: (no value)



Subject: Quoted numeric HTML attributes break almost all tests
On all systems I've tried (Debian and Ubuntu), HTML::CalendarMonth fails almost all its tests: Failed 1/2 tests, 50.00% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------ - t/01_autodetect.t 51 13056 51 51 100.00% 1-51 t/02_timelocal.t 51 13056 53 51 96.23% 3-53 t/04_datemanip.t 53 13568 55 53 96.36% 3-55 t/05_datecalc.t 53 13568 55 53 96.36% 3-55 t/06_cal.t 51 13056 53 51 96.23% 3-53 t/20_i8n.t 1 256 2 1 50.00% 2 55 subtests skipped. Failed 6/8 test scripts, 25.00% okay. 260/327 subtests failed, 20.49% okay. The reason is that numeric HTML attributes are now quoted and the test script doesn't expect it. Here's a truncated example of the error that's repeated with variations a few hundred times: # Failed test '(2000/10 Mon 1st day) using auto-select' # in /root/.cpan/build/HTML-CalendarMonth-1.18/t/testload.pm at line 92. # got: '<table bgcolor="white" border="1" cellpadding="0" cellspacing="0"><tr align="center"><td align="left" colspan="5"> [...] # ' # expected: '<table bgcolor="white" border=1 cellpadding=0 cellspacing=0><tr align="center"><td align="left" colspan=5> [...] # ' t/01_autodetect....NOK 1
From: ntyni [...] iki.fi
On Fri Sep 08 17:06:40 2006, JAMCC wrote: Show quoted text
> On all systems I've tried (Debian and Ubuntu), HTML::CalendarMonth > fails almost all its tests:
Show quoted text
> The reason is that numeric HTML attributes are now quoted and the test > script doesn't expect it.
This difference was introduced in HTML::Tree 3.19_02: * All values in tags are now double-quoted. Previously, all-numeric values weren't quoted. The simple way to fix the tests is # perl -pi.bak -e 's/=(\d+)/="$1"/g' t/test* t/20_i8n.t FWIW, this is also Debian bug #420048, http://bugs.debian.org/420048 . Cheers, -- Niko Tyni ntyni@iki.fi
From: rjbs [...] cpan.org
On Tue Apr 24 08:31:18 2007, ntyni@iki.fi wrote: Show quoted text
> FWIW, this is also Debian bug #420048, http://bugs.debian.org/420048 .
This is also blocking the next release of Rubric. -- rjbs
Fixed in 1.19.