Skip Menu |

This queue is for tickets about the PAR-Dist CPAN distribution.

Report information
The Basics
Id: 21366
Status: resolved
Priority: 0/
Queue: PAR-Dist
People
Owner: smueller [...] cpan.org
Requestors: kane [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.19
Fixed in: (no value)

History Show all quoted text
  Thu Sep 07 07:34:44 2006 kane [...] cpan.org - Ticket created
Subject: PAR::Dist name/version probing too naive
Greetings, I've been playing with PAR::Dist for a while, and noticed the following issues. I've just addressed them in text now, in the hope they are trivial for you to spot and address. in sub blib_to_par, a META.yml is inspected for version/name information. If that fails, the Makefile/Build is not checked. If there is no Makefile, name/version probing will fail. This will be the case when the distribution uses Module::Build rather than EU::MM and lacks a meta.yml No check that $version and $name are defined when they are used, resulting in numerous warnings, and faulty named par files: Use of uninitialized value in substitution (s///) at /opt/lib/perl5/site_perl/5.8.8/PAR/Dist.pm line 212. Use of uninitialized value in substitution (s///) at /opt/lib/perl5/site_perl/5.8.8/PAR/Dist.pm line 213. Use of uninitialized value in concatenation (.) or string at /opt/lib/perl5/site_perl/5.8.8/PAR/ Dist.pm line 215. Use of uninitialized value in concatenation (.) or string at /opt/lib/perl5/site_perl/5.8.8/PAR/ Dist.pm line 215. Use of uninitialized value in concatenation (.) or string at /opt/lib/perl5/site_perl/5.8.8/PAR/ Dist.pm line 218. Use of uninitialized value in concatenation (.) or string at /opt/lib/perl5/site_perl/5.8.8/PAR/ Dist.pm line 218. Successfully created binary distribution '/Users/kane/sources/svk/oss/cpanplus-dist-par/ t/--darwin-2level-5.8.8.par'.
  Mon Sep 18 08:25:42 2006 smueller [...] cpan.org - Correspondence added
Hi Jos, oddly, this ticket went by unnoticed so far. I didn't seem to get a mail from RT about it. I'll look into this ASAP, but that might be as late as next month. Best regards, Steffen
  Mon Sep 18 08:25:43 2006 The RT System itself - Status changed from 'new' to 'open'
  Mon Sep 18 08:25:46 2006 smueller [...] cpan.org - Given to SMUELLER
  Mon Sep 18 18:21:35 2006 smueller [...] cpan.org - Correspondence added
On Do. 07. Sep. 2006, 07:34:44, KANE wrote: [...] Show quoted text
> in sub blib_to_par, a META.yml is inspected for version/name > information. > If that fails, the Makefile/Build is not checked. > > If there is no Makefile, name/version probing will fail. This will be > the case when > the distribution uses Module::Build rather than EU::MM and lacks a > meta.yml > > No check that $version and $name are defined when they are used, > resulting in > numerous warnings, and faulty named par files:
[...] Hi again, I addressed this in the svn version of PAR::Dist. http://svn.openfoundry.org/par/PAR-Dist/ testing welcome. :) What I have not done is make the probing any better. It will still fail if there is no META.yml for Module::Build based modules. But it has a helpful error message now. If you have an idea on how to make it more robust, I'm all open. Steffen
  Mon Sep 18 18:21:37 2006 smueller [...] cpan.org - Status changed from 'open' to 'resolved'