Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 21365
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: Bernhard.Schmalhofer [...] gmx.de
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: 0.19
Fixed in: (no value)

History Show all quoted text
  Thu Sep 07 07:04:35 2006 Bernhard.Schmalhofer [...] gmx.de - Ticket created
Hi I upgraded to Perl::Critic 0.19 and got a complaint about a DESTROY sub. I think that DESTROY is commonly overridden, so Perl::Critic shouldn't complain about it.
  Thu Sep 07 09:48:14 2006 cpan [...] clotho.com - Correspondence added
Subject: DESTROY problem
On Thu Sep 07 07:04:35 2006, Bernhard.Schmalhofer@gmx.de wrote: Show quoted text
> Hi I upgraded to Perl::Critic 0.19 and got a complaint about a DESTROY > sub. > > I think that DESTROY is commonly overridden, so Perl::Critic shouldn't > complain about it.
Hi Bernhard! Can you give the actual complaint message? I'll need to see that to know which Policy module is causing the problem. -- Chris
  Thu Sep 07 09:48:16 2006 The RT System itself - Status changed from 'new' to 'open'
  Mon Sep 11 04:14:34 2006 Bernhard.Schmalhofer [...] gmx.de - Correspondence added
From: Bernhard.Schmalhofer [...] gmx.de
On Do. 07. Sep. 2006, 09:48:14, CLOTHO wrote: Show quoted text
> Can you give the actual complaint message? I'll need to see that to > know which Policy module is causing the problem. > -- Chris
Hi Chris, sorry, I didn't think of that. The message is: Bmax/t/perlcritic....ok 17/24 # Failed test 'Test::Perl::Critic for "lib/Biomax/Bmax/Config.pm"' # in Bmax/t/perlcritic.t at line 48. # # Perl::Critic found these violations in "lib/Biomax/Bmax/Config.pm": Bmax/t/perlcritic....NOK 18# Subroutines::ProhibitBuiltinHomonyms: Subroutine name is a homonym for builtin function at line 323 See page 177 of PBP Actually I have an empty DESTROY subroutine only because earlier I habe a sub AUTOLOAD ## no critic Regards, Bernhard
  Mon Sep 11 10:25:22 2006 cpan [...] clotho.com - Correspondence added
From: CLOTHO [...] cpan.org
Bernhard, Jeff took a crack at fixing this in the just-released-to-CPAN Perl::Critic v0.20. Can you try that version and check if it works better for you? Thanks, Chris
  Tue Sep 12 04:00:57 2006 Bernhard.Schmalhofer [...] gmx.de - Correspondence added
Subject: Subroutines::ProhibitBuiltinHomonyms fixed for DESTROY
From: Bernhard.Schmalhofer [...] gmx.de
On Mo. 11. Sep. 2006, 10:25:22, CLOTHO wrote: Show quoted text
> Jeff took a crack at fixing this in the just-released-to-CPAN > Perl::Critic v0.20. Can you try that version and check if it works > better for you?
Hi, thanks for the quick fix. Looks fine in Perl::Critic v0.20. CU, Bernhard
  Fri Sep 15 04:19:21 2006 thaljef [...] cpan.org - Correspondence added
Fixed in 0.20. Verified by Bernhard.
  Fri Sep 15 04:19:23 2006 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Feb 19 17:02:23 2013 thaljef [...] cpan.org - Subject changed from (no value) to 'DESTROY incorrectly identified as a homonym'