Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 21352
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: EWILHELM [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.18
  • 0.18_01
  • 0.19
Fixed in: (no value)



Subject: Test t/06... and t/20... failure with PPI 1.117
The expected output appears to have changed after PPI 1.115. Below is the report from testing Perl::Critic 0.19 on PPI 1.117. Downgrading PPI makes them pass. t/06_violation........................NOK 18# Failed test 'location' # in t/06_violation.t at line 54. # Structures begin differing at: # $got->[0] = '1' # $expected->[0] = '0' t/06_violation........................NOK 23# Failed test 'to_string' # in t/06_violation.t at line 64. # '1,1,Foo,Bar,main, No diagnostics available # ,Hello World;' # doesn't match '(?msx-i:\A 0,0,Foo,Bar,main,(?msx-i: \s* No [ ] diagnostics [ ] available \s* ),Hello\ World\; \z)' t/06_violation........................NOK 24 # Failed test 'stringify' # in t/06_violation.t at line 65. # '1,1,Foo,Bar,main, No diagnostics available # ,Hello World;' # doesn't match '(?msx-i:\A 0,0,Foo,Bar,main,(?msx-i: \s* No [ ] diagnostics [ ] available \s* ),Hello\ World\; \z)' # Looks like you failed 3 tests of 32. t/20_policies_inputoutput.............ok 16/19 # Failed test 'InputOutput::ProhibitInteractiveTest' # in t/20_policies_inputoutput.t at line 337. # got: '2' # expected: '3' t/20_policies_inputoutput.............NOK 18# Looks like you failed 1 test of 19. t/06_violation.t 3 768 32 3 9.38% 18 23-24 t/20_policies_inputoutput.t 1 256 19 1 5.26% 18
From: CLOTHO [...] cpan.org
Known and fixed in SVN. Now we're just waiting for Jeff to get back from vacation to release a new Perl-Critic. :-) Thanks for the report. -- Chris
This is fixed in 0.20. Thanks for reporting it.