Skip Menu |

This queue is for tickets about the WWW-TV CPAN distribution.

Report information
The Basics
Id: 21161
Status: resolved
Worked: 20 min
Priority: 0/
Queue: WWW-TV

People
Owner: tigris [...] cpan.org
Requestors: ul.muller [...] bluewin.ch
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.04
Fixed in: (no value)



Subject: Minor Bug in sub _fill_vitals in WWW::TV::Episode
Date: Thu, 24 Aug 2006 12:57:59 +0200
To: <bug-WWW-TV [...] rt.cpan.org>
From: Ulrich Müller <ul.muller [...] bluewin.ch>
Hi there! When an episode hasn't yet been aired, the aired label gets the value "n/a" which wasn't properly parsed in _fill_vitals. Problem occurs in this code: #!/usr/bin/perl use WWW::TV; my $series = WWW::TV::Series->new(name => 'House'); my @episodes = $series->episodes; print $episodes[51]->id."\n"; print $episodes[51]->episode_number."\n"; #Doesn't output correct episode nr I suggest something like this, since it seems to have fixed it for me: First\sAired:\s(?:\w+\s(\w+\s\d\d?,\s\d{4})|n/a) On line 340. Thanks for a great package otherwise and keep up the good work. Best wishes, Ulrich Müller Switzerland
RT-Send-CC: stennie [...] cpan.org
Hi Ulrich, Thanks a bunch for your fix. It has been implemented by Stephen Tennie while he was working on some new features. It will be up with the next release which will hopefully be in the next week or so. Apologies for the delay, the RT system is a bit barfed at the moment and I didn't get a notification of your ticket :-( Whilst the fix is implemented already, I have been trying to add a test case for it in the unit tests so I don't break it again in the future. I'm having trouble finding an episode that currently displays 'n/a' as the First Aired Date. I wonder if you might know of any so that I can do an initial test for now? The House episode you listed in the ticket has been updated with a date since ticket creation. I also wonder if either you or Stephen (cc'd cos I am lazy) might have any ideas about a test case that would always display 'n/a'? I was thinking of picking a current season and just getting the last episode of the season, then wrapping it in a SKIP block during the non-rating periods. But as you can see on TV.com, even now half way through the season, it looks as though they all have aired dates? regards, Danial
Subject: RE: [rt.cpan.org #21161] Minor Bug in sub _fill_vitals in WWW::TV::Episode
Date: Wed, 21 Feb 2007 19:45:37 +0100
To: <bug-WWW-TV [...] rt.cpan.org>
From: Ulrich Müller <ul.muller [...] bluewin.ch>
Hi Danial, No Problem, I was glad to help out :) Show quoted text
> I'm having trouble finding an episode that currently displays > 'n/a' as the First Aired Date. I wonder if you might know of > any so that I can do an initial test for now? The House > episode you listed in the ticket has been updated with a date > since ticket creation.
It seems like tv.com doesn't really stick to 'n/a'. I was looking for a test case and I spotted this: http://www.tv.com/scrubs/show/3613/episode_listings.html?season=6&tag=nav_ba r;6 Looks like they either switched to this notation ("0/0/0") or "n/a" was just an exception. In any case I think my quick hack wouldn’t hold up since it used the 'n/a' string explicitly. Something more robust would be desirable :) Show quoted text
> I also wonder if either you or Stephen (cc'd cos I am lazy) > might have any ideas about a test case that would always > display 'n/a'? I was thinking of picking a current season and > just getting the last episode of the season, then wrapping it > in a SKIP block during the non-rating periods. But as you can > see on TV.com, even now half way through the season, it looks > as though they all have aired dates?
Just a thought, why not let google do the work? http://www.google.ch/search?hl=de&q=site%3Atv.com+%2B%220%2F0%2F0%22&btnG=Go ogle-Suche&meta= Regards, Ulrich