Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 21070
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: claco [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.18_01
Fixed in: 0.19
Attachments
signature.asc

History Show all quoted text
  Fri Aug 18 15:18:45 2006 claco [...] cpan.org - Ticket created
Subject: ProhibitNoisyQuotes Hates Overload
It appears that ValuesAndExpressions::ProhibitNoisyQuotes doesn't like overload lines, specifically: # Quotes used with a noisy string at line 6, column 14: ValuesAndExpressions::ProhibitNoisyQuotes Severity 2 # use overload '""' => \&stringify, fallback => 1;
  Fri Aug 18 21:25:33 2006 chris [...] chrisdolan.net - Correspondence added
Subject: Re: [rt.cpan.org #21070] ProhibitNoisyQuotes Hates Overload
Date: Fri, 18 Aug 2006 20:25:11 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Chris Dolan <chris [...] chrisdolan.net>
On Aug 18, 2006, at 2:18 PM, via RT wrote: Show quoted text
> It appears that ValuesAndExpressions::ProhibitNoisyQuotes doesn't like > overload lines, specifically: > > # Quotes used with a noisy string at line 6, column 14: > ValuesAndExpressions::ProhibitNoisyQuotes Severity 2 > # use overload '""' => \&stringify, fallback => 1;
This is better written as use overload q{""} => \&stringify, fallback => 1; Nonetheless, I've added an exception for "use overload" since it's so common to write as '""'. This change will appear in the next release. Chris -- Chris Dolan, Software Developer, http://www.chrisdolan.net/ Public key: http://www.chrisdolan.net/public.key vCard: http://www.chrisdolan.net/ChrisDolan.vcf
  Fri Aug 18 21:25:34 2006 The RT System itself - Status changed from 'new' to 'open'
  Sat Aug 19 09:33:09 2006 claco [...] chrislaco.com - Correspondence added
CC: CLACO [...] cpan.org
Subject: Re: [rt.cpan.org #21070] ProhibitNoisyQuotes Hates Overload
Date: Sat, 19 Aug 2006 09:33:17 -0400
To: bug-Perl-Critic [...] rt.cpan.org
From: "Christopher H. Laco" <claco [...] chrislaco.com>
Chris Dolan via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=21070 > > > On Aug 18, 2006, at 2:18 PM, via RT wrote: >
>> It appears that ValuesAndExpressions::ProhibitNoisyQuotes doesn't like >> overload lines, specifically: >> >> # Quotes used with a noisy string at line 6, column 14: >> ValuesAndExpressions::ProhibitNoisyQuotes Severity 2 >> # use overload '""' => \&stringify, fallback => 1;
> > This is better written as > use overload q{""} => \&stringify, fallback => 1;
I agree, if only the overload pragma pod gets fixed. :-) Show quoted text
> Nonetheless, I've added an exception for "use overload" since it's so > common to write as '""'. This change will appear in the next release. >
Thanks. Updating from svn now. -=Chris
Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

  Sun Aug 20 21:09:38 2006 thaljef [...] cpan.org - Correspondence added
Fixed in version 0.19.
  Sun Aug 20 21:09:40 2006 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Aug 21 23:14:07 2006 thaljef [...] cpan.org - Fixed in 0.19 added