Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Email-Valid CPAN distribution.

Report information
The Basics
Id: 20943
Status: resolved
Priority: 0/
Queue: Email-Valid

People
Owner: Nobody in particular
Requestors: robbiebow [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: Possible improvement to details method
I think $self->{details} is unneccessary as $Details can be returned from the details method whether called as a class or object method. For example, details could be simplified to: sub details { my $self = shift; return $Details unless @_; $Details = shift; return undef; } And line 46 removed altogether: $self->{details} = $Details = undef; Or am I missing something??? ;o)
You were missing something. my $valid_alpha = Email::Valid->new; my $valid_bravo = Email::Valid->new; $valid_alpha->address('somebody@example.com'); $valid_bravo->address('somebody@examp!e.com'); print $valid_alpha->details; Your changes would cause that to return the details for the validation done by bravo. $Details are global to the class. ->details are local to the object. -- rjbs
From: robbiebow [...] canada.com
Of course! I just knew I must have been missing something.
(closing ticket re-opened by reply) -- rjbs