Skip Menu |

This queue is for tickets about the GDGraph CPAN distribution.

Maintainer(s)' notes

There are plenty of good ideas of what people can do published here on the queue. Turning a patch from the tracker into a pull request is not one of them. In order to get maintainers' attention way more quickier, PR should have at least a sample included. We know it's hard to test images generating software, but it doesn't mean we can not test numbers produced by intermediate algorithms used to generate these images, so either a test or a sample.

Report information
The Basics
Id: 20802
Status: resolved
Priority: 0/
Queue: GDGraph
People
Owner: bwarfield [...] cpan.org
Requestors: john.mccarty [...] coronasolutions.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.4308
Fixed in: 1.44

History Show all quoted text
  Tue Aug 01 19:26:15 2006 john.mccarty [...] coronasolutions.com - Ticket created
Subject: bug in GD::Graph
Date: Tue, 01 Aug 2006 17:27:03 -0600
To: bug-GDGraph [...] rt.cpan.org
From: John McCarty <john.mccarty [...] coronasolutions.com>
Hello, I'm working on some Perl code, and noticed what appears to be a bug in GD::Graph.... maybe I'm not seeing it correctly though. In Graph.pm, function "_read_logo_file", the variable $gdimport is set equal to the return from $self->export_format. "export_format" returns either an array of image formats that the system can handle, or the first item in that array. In this case ("_read_logo_file"), it will return the first item in that array, which is "gif". So, the variable $gdimport is set to the string "newFromGif", always. This posses a problem in that the LOGO being used/read may not be a gif file. In my case, it is a png. As the code is, it may return a file format that is not the same as the file being opened, resulting in an error. Perhaps "_read_logo_file" should get the array of possible formats, then loop thru that array trying to open the LOGO file... if it is able to open it with one of the formats, great; if not, then issue the error about not being able to read the file. thank you, john mccarty
  Wed Aug 02 11:43:00 2006 bwarfield [...] cpan.org - Status changed from 'new' to 'open'
  Wed Aug 02 11:43:03 2006 bwarfield [...] cpan.org - Severity Normal added
  Wed Aug 02 11:43:35 2006 bwarfield [...] cpan.org - Broken in 1.4308 added
  Wed Aug 02 11:46:14 2006 bwarfield [...] cpan.org - Taken
  Thu Apr 12 00:37:28 2007 bwarfield [...] cpan.org - Subject changed from 'bug in GD::Graph' to 'bug in GD::Graph logo handling (alternate format support)'
  Thu Apr 12 00:37:32 2007 bwarfield [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Apr 26 12:11:06 2007 bwarfield [...] cpan.org - Fixed in 1.44 added