Bug #20784 for Mozilla-DOM: build fails with firefox-devel-1.5.0.5

Tue Aug 01 05:12:43 2006 altblue [...] n0i.net - Ticket created

Subject:

build fails with firefox-devel-1.5.0.5

Switching from mozilla-devel to firefox-devel, build fails with ugly error: xs/DOM.xs:12674: error: no matching function for call to 'nsIDOMNSHTMLDocument::Open(nsIDOMDocument**)' /usr/include/firefox-1.5.0.5/dom/nsIDOMNSHTMLDocument.h:67: note: candidates are: virtual nsresult nsIDOMNSHTMLDocument::Open(const nsACString&, PRBool, nsIDOMDocument**) Underlying info: OS: GNU/Linux (kernel: 2.6.17, distro: Fedora Development) Perl: 5.8.8 Firefox: 1.5.0.5 GCC: 4.1.1 Glibc: 2.4.90 In order to reach to this error, I had to add "necko" to the header files search list (similar to #17758): -I%(pkg-config --variable=includedir firefox-xpcom)/necko Is this worthy to be also notified upstream (Mozilla/Fedora)? As I see, no Firefox library adds 'necko' to its searchlist.

Wed Aug 02 05:17:14 2006 slanning [...] cpan.org - Correspondence added

From:

SLANNING [...] cpan.org

Thanks, I'll try to look at it soon. I think the pkg-config list depends on the distribution. I don't know if they have reasons for not including necko in the list, so yes you might want to discuss it with them.

Wed Aug 02 05:17:16 2006 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 20 10:42:38 2006 AYOUNG [...] cpan.org - Correspondence added

On Wed Aug 02 05:17:14 2006, SLANNING wrote: Show quoted text

> I think the pkg-config list depends on the distribution. > I don't know if they have reasons for not including necko > in the list, so yes you might want to discuss it with them.

I'm getting the same thing. Before adding necko and necko2 to the Makefile.PL: xs/DOM.xs: In function 'void XS_Mozilla__DOM__NSHTMLDocument_Open(CV*)': xs/DOM.xs:12674: error: no matching function for call to 'nsIDOMNSHTMLDocument::Open(nsIDOMDocument**)' /usr/lib64/mozilla-firefox/include/dom/nsIDOMNSHTMLDocument.h:67: note: candidates are: virtual nsresult nsIDOMNSHTMLDocument::Open(const nsACString&, PRBool, nsIDOMDocument**) after: xs/DOM.xs: In function 'void XS_Mozilla__DOM__NSHTMLDocument_Open(CV*)': xs/DOM.xs:12674: error: no matching function for call to 'nsIDOMNSHTMLDocument::Open(nsIDOMDocument**)' /usr/lib64/mozilla-firefox/include/dom/nsIDOMNSHTMLDocument.h:67: note: candidates are: virtual nsresult nsIDOMNSHTMLDocument::Open(const nsACString&, PRBool, nsIDOMDocument**) They are identical. I did a grep for Open in the necko and necko2 directory there a none that match nsIDOMNSHTMLDocument and got nothing, so I did it from the include directory: sweetums include # pwd /usr/lib64/mozilla-firefox/include sweetums include # grep -r '::Open' * | grep nsIDOMNSHTMLDocument dom/nsIDOMNSHTMLDocument.h:NS_IMETHODIMP nsDOMNSHTMLDocument::Open(const nsACString & aContentType, PRBool aReplace, nsIDOMDocument **_retval) Looking at the xs/DOM.xs file it looks like the prototypes don't match. I'm not sure how to go about fixing this though.

Mon Nov 20 12:38:02 2006 slanning [...] cpan.org - Correspondence added

From:

SLANNING [...] cpan.org

I have the patch (attached), just Gtk2::MozEmbed was segfaulting last I tried it, and I didn't get around to fixing that yet. I'll try to get a newer release out soon....

diff -r -u Mozilla-DOM-0.20/xs/DOM.xs Mozilla-DOM-0.21/xs/DOM.xs --- Mozilla-DOM-0.20/xs/DOM.xs 2005-09-29 05:15:06.000000000 +0300 +++ Mozilla-DOM-0.21/xs/DOM.xs 2006-11-14 16:56:16.000000000 +0200 @@ -12666,0 +12666,0 @@ ## Open(nsIDOMDocument **_retval) nsIDOMDocument * -moz_dom_Open (nshtmldocument) +moz_dom_Open (nshtmldocument, nsEmbedCString & contentType , PRBool & replace) nsIDOMNSHTMLDocument *nshtmldocument; PREINIT: nsIDOMDocument * _retval; CODE: - nshtmldocument->Open(&_retval); + nshtmldocument->Open(contentType, replace, &_retval); RETVAL = _retval; OUTPUT: RETVAL