Bug #20711 for PAR: par.pl does not strip \r from values looked up in META.yml

Thu Jul 27 05:14:41 2006 djo [...] cpan.org - Ticket created

Subject:

par.pl does not strip \r from values looked up in META.yml

Hi, par.pl does not strip \r from values looked up in META.yml When doing: par.pl -i <package-dir> You'll get a par file that contains \r charaters if the META.yml is using \n\r as line seperator. An example of this is META.yml in HTML::Prototype -- Best regards, David Jack Olrik <david@olrik.dk> http://david.olrik.dk GnuPG fingerprint C290 0A4A 0CCC CBA8 2B37 E18D 01D2 F6EF 2E61 9894 ["The first rule of Perl club is You do not talk about Perl club"]

Fri Jul 28 04:58:25 2006 smueller [...] cpan.org - Correspondence added

On Do. 27. Jul. 2006, 05:14:41, DJO wrote: Show quoted text

> par.pl does not strip \r from values looked up in META.yml > > When doing: > > par.pl -i <package-dir> > > You'll get a par file that contains \r charaters if the META.yml is using > \n\r as line seperator. > > An example of this is META.yml in HTML::Prototype

Hi, I have just fixed a similar bug in PAR::Dist. (Not on CPAN yet.) Can you give a more detailed example of what you are doing? Do you generate a .par package from a CPAN distribution and try to install it with par.pl -i foo? (If so, how do you generate the .par distro?) It's not that I don't understand the problem. It's just that it would really help if I knew where to look. (The code in PAR can be a bit difficult to deal with at times, trust me. :( ) Thanks for reporting, Steffen

Fri Jul 28 04:58:26 2006 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 28 04:58:27 2006 smueller [...] cpan.org - Given to SMUELLER

Fri Jul 28 06:16:21 2006 djo [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #20711] par.pl does not strip \r from values looked up in META.yml
Date:	Fri, 28 Jul 2006 12:11:56 +0200
To:	bug-PAR [...] rt.cpan.org
From:	David Jack Olrik <djo [...] cpan.org>

On 28/07/2006, at 10.58, Steffen Müller via RT wrote: Show quoted text

> Can you give a more detailed example of what you are doing? Do you > generate a .par package from a CPAN distribution and try to install it > with par.pl -i foo? (If so, how do you generate the .par distro?)

I have a module that uses CPANPLUS::Backend to fetch the tar from cpan, extract it, build it, and then package it with par.pl -p. Here is an extraxt from my code that demonstrates the problem:

Message body is not shown because sender requested not to inline it.

It'll fetch HTML::Prototype, unpack it and par'ify it. You'll end up with at par file with ^M's around the version number. I am 100% sure that the ^M is comming from META.yml, because uncommenting line 12 will make them go away. Show quoted text

> It's not that I don't understand the problem. It's just that it would > really help if I knew where to look. (The code in PAR can be a bit > difficult to deal with at times, trust me. :( )

Been there, done that ;) Show quoted text

> Thanks for reporting,

=) -- Best regards, David Jack Olrik <david@olrik.dk> http://david.olrik.dk GnuPG fingerprint C290 0A4A 0CCC CBA8 2B37 E18D 01D2 F6EF 2E61 9894 ["The first rule of Perl club is You do not talk about Perl club"]

Fri Jul 28 07:20:36 2006 smueller [...] cpan.org - Correspondence added

Hi, On Fr. 28. Jul. 2006, 06:16:21, DJO wrote: Show quoted text

> I have a module that uses CPANPLUS::Backend to fetch the tar from cpan, > extract it, build it, and then package it with par.pl -p.

If you do not need to use CPANPLUS and would also use CPAN, you can use PAR::Dist::FromCPAN for this task. Show quoted text

> Here is an extraxt from my code that demonstrates the problem:

Great. Thanks. As I said, I fixed pretty much this exact bug in PAR::Dist. I'll see whether I can find it in PAR. Steffen

Fri Jul 28 07:39:29 2006 smueller [...] cpan.org - Correspondence added

Actually, I am pretty sure that this was "only" a bug in PAR::Dist. Try checking out PAR::Dist 0.15 via subversion from http://svn.openfoundry.org/par/PAR-Dist and install that. Retry your example. I'm confident it'll work. Steffen

Fri Jul 28 07:39:37 2006 smueller [...] cpan.org - Status changed from 'open' to 'resolved'