Bug #20698 for Language-Functional: Test failures

I changes any() and all() implementation to pass tests. Not sure if this what author intended because there are following tests contradicting the short-circuiting advertised on POD: ok(eval {show(all(\&odd, integers))}, '0'); # 81 ok(eval {show(all {1} integers)}, undef); # 82 (fails!) According test 81 all() must check elements of infinite list and not to confess. According test 81 all() must recognize the check never ends and confess. So in worst case, all() must check all members with index < INFINITE and confess after that.

From 73c916ba63070d9076b1286220ea7544d24925bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 14 Jun 2011 18:19:25 +0200 Subject: [PATCH] Fix any() and all() on infinite list --- Functional.pm | 31 ++++++++++++++++++++++++------- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/Functional.pm b/Functional.pm index 78cfadd..493979c 100644 --- a/Functional.pm +++ b/Functional.pm @@ -1320,9 +1320,18 @@ In Haskell: sub any(&$) { my($p, $xs) = @_; - map { - return 1 if $p->($_); - } @{$xs}; + my $n = 0; + my $size = $#{$xs}; + while ($n <= $size) { + return 1 if $p->($xs->[$n]); + $n++; + } + if ($size == $Language::Functional::INFINITE + or $size == $Language::Functional::INFINITE - 1 + ) { + confess "Evaluating predicate on inifinite number of elements " . + "would never end!"; + } return 0; } @@ -1345,10 +1354,18 @@ In Haskell: sub all(&$) { my($p, $xs) = @_; - map { - my $x = $_; - return 0 if not $p->($x); - } @{$xs}; + my $n = 0; + my $size = $#{$xs}; + while ($n <= $size) { + return 0 if not $p->($xs->[$n]); + $n++; + } + if ($size == $Language::Functional::INFINITE + or $size == $Language::Functional::INFINITE - 1 + ) { + confess "Evaluating predicate on inifinite number of elements " . + "would never end!"; + } return 1; } -- 1.7.5.4