Bug #20647 for PPI:

Mon Jul 24 12:07:35 2006 jjore [...] cpan.org - Ticket created

PPI can't handle <<HERE_DOCs. #!/usr/bin/perl use Test::More tests => 1; use PPI; my $src = <<'TEXT'; print <<'BAR'; Here is some text BAR TEXT is( PPI::Document->new( \$src ), $src ) 1..1 not ok 1 # Failed test in tmp/ppi at line 10. # got: 'print <<'BAR'; # ' # expected: 'print <<'BAR'; # Here is some text # BAR # ' # Looks like you failed 1 test of 1.

Mon Jul 24 12:14:14 2006 adam [...] phase-n.com - Correspondence added

Subject:	Re: [rt.cpan.org #20647]
Date:	Tue, 25 Jul 2006 00:13:50 +0800
To:	bug-PPI [...] rt.cpan.org
From:	Adam Kennedy <adam [...] phase-n.com>

The test code is invalid, documents stringify naively. The correct test code is is( PPI::Document->new( \$src )->serialize, $src ); Adam K via RT wrote: Show quoted text

> Mon Jul 24 12:07:35 2006: Request 20647 was acted upon. > Transaction: Ticket created by JJORE > Queue: PPI > Subject: (No subject given) > Broken in: 1.115 > Severity: Important > Owner: Nobody > Requestors: JJORE@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=20647 > > > > PPI can't handle <<HERE_DOCs. > > #!/usr/bin/perl > use Test::More tests => 1; > use PPI; > my $src = <<'TEXT'; > print <<'BAR'; > Here is some text > BAR > TEXT > > is( PPI::Document->new( \$src ), $src ) > > > 1..1 > not ok 1 > # Failed test in tmp/ppi at line 10. > # got: 'print <<'BAR'; > # ' > # expected: 'print <<'BAR'; > # Here is some text > # BAR > # ' > # Looks like you failed 1 test of 1.

Mon Jul 24 12:14:15 2006 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 24 13:20:24 2006 twists [...] gmail.com - Correspondence added

CC:	JJORE [...] cpan.org
Subject:	Re: [rt.cpan.org #20647]
Date:	Mon, 24 Jul 2006 12:19:36 -0500
To:	bug-PPI [...] rt.cpan.org
From:	"Joshua ben Jore" <twists [...] gmail.com>

On 7/24/06, adam@phase-n.com via RT <bug-PPI@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=20647 > > > The test code is invalid, documents stringify naively. > > The correct test code is > > is( PPI::Document->new( \$src )->serialize, $src );

Ah. Perl::Critic was using the overloaded "" stringification which triggered this. I saw the same behavior in PPI and figured it was PPI's problem. I didn't realize the overloaded "" was producing wrong output just because it wasn't named ->serialize. Is there a good reason to overload "" to ->content()? I'd think it'd be more correct to overload to ->serialize(). Josh

Thu Aug 31 09:09:10 2006 adamk [...] cpan.org - Correspondence added

On Mon Jul 24 13:20:24 2006, twists@gmail.com wrote: Show quoted text

> On 7/24/06, adam@phase-n.com via RT <bug-PPI@rt.cpan.org> wrote:

> > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=20647 > > > > > The test code is invalid, documents stringify naively. > > > > The correct test code is > > > > is( PPI::Document->new( \$src )->serialize, $src );

> > Ah. Perl::Critic was using the overloaded "" stringification which > triggered this. I saw the same behavior in PPI and figured it was > PPI's problem. I didn't realize the overloaded "" was producing wrong > output just because it wasn't named ->serialize. > > Is there a good reason to overload "" to ->content()? I'd think it'd > be more correct to overload to ->serialize(). > > Josh

When treated as a simple string, you can't fully serialize validly. You can ONLY do it when you fully output to a file (due to the nature of the way here-doc content works). So for the moment, no I'm keeping it as content, mostly because if I change it to serialize, it means that a document stringifies differently to an element. And I'm dubious about that.

Thu Aug 31 09:10:32 2006 adamk [...] cpan.org - Correspondence added

WONTFIX

Thu Aug 31 09:10:34 2006 adamk [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #20647 for PPI:

Preferred bug tracker