Bug #20635 for Sys-Syslog: 'make test' fails under Cygwin

Sun Jul 23 14:26:47 2006 jdhedden [...] cpan.org - Ticket created

Subject:

'make test' fails under Cygwin

'make test' fails when building with Perl 5.8.8 under Cygwin: t/00-load......ok 1/1# Testing Sys::Syslog 0.17, Perl 5.008008, /usr/bin/perl.exe t/00-load......ok t/constants....ok 6/88 skipped: irrelevant test in this case t/distchk......skipped all skipped: Test::Distribution required for checking distribution t/pod..........skipped all skipped: Test::Pod 1.14 required for testing POD t/podcover.....skipped all skipped: Test::Pod::Coverage 1.06 required for testing POD coverage t/podspell.....skipped all skipped: Pod spelling: for developer interest only :) t/portfs.......skipped all skipped: Test::Portability::Files required for testing filenames portability t/syslog.......ok 1/179Use of uninitialized value in -w at /admin/cpan/build/Sys-Syslog-0.17/blib/lib/Sys/Syslog.pm line 168. Use of uninitialized value in concatenation (.) or string at /admin/cpan/build/Sys-Syslog-0.17/blib/lib/Sys/Syslog.pm line 169. Use of uninitialized value in -w at /admin/cpan/build/Sys-Syslog-0.17/blib/lib/Sys/Syslog.pm line 168. Use of uninitialized value in concatenation (.) or string at /admin/cpan/build/Sys-Syslog-0.17/blib/lib/Sys/Syslog.pm line 169. # Failed test 'setlogsock() should return true: ''' # in t/syslog.t at line 184. t/syslog.......NOK 156# Looks like you failed 1 test of 179. t/syslog.......dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 156 Failed 1/179 tests, 99.44% okay (less 60 skipped tests: 118 okay, 65.92%) Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/syslog.t 1 256 179 1 156 5 tests and 66 subtests skipped. Failed 1/8 test scripts. 1/268 subtests failed. Files=8, Tests=268, 2 wallclock secs ( 1.30 cusr + 0.49 csys = 1.79 CPU) Failed 1/8 test programs. 1/268 subtests failed. Full output attached. 'perl -V' attached.

Subject:

test.out

Download test.out
application/octet-stream 1.8k

Message body not shown because it is not plain text.

Subject:

perl.out

Download perl.out
application/octet-stream 2.3k

Message body not shown because it is not plain text.

Sun Jul 23 16:36:32 2006 SAPER [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #20635] 'make test' fails under Cygwin
Date:	Sun, 23 Jul 2006 22:36:11 +0200
To:	bug-Sys-Syslog [...] rt.cpan.org
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Show quoted text

> 'make test' fails when building with Perl 5.8.8 under Cygwin: > > # Failed test 'setlogsock() should return true: ''' > # in t/syslog.t at line 184.

Thanks for your report. Could you send me the output of the following commands? $ perl -MSys::Syslog -le 'print Sys::Syslog::_PATH_LOG()' $ prove -bv t/syslog.t Sébastien Aperghis-Tramoni -- - --- -- - -- - --- -- - --- -- - --[ http://maddingue.org ] Close the world, txEn eht nepO

Sun Jul 23 16:36:33 2006 The RT System itself - Status changed from 'new' to 'open'

Mon Jul 24 14:16:40 2006 SAPER [...] cpan.org - Taken

Thu Aug 03 05:04:10 2006 SAPER [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #20635] 'make test' fails under Cygwin
Date:	Thu, 03 Aug 2006 11:03:53 +0200
To:	bug-Sys-Syslog [...] rt.cpan.org, "Jerry D. Hedden" <jdhedden [...] cpan.org>
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Hello, I didn't heard back anything from you. Did you receive my previous mail ? Show quoted text

> > 'make test' fails when building with Perl 5.8.8 under Cygwin: > > > > # Failed test 'setlogsock() should return true: ''' > > # in t/syslog.t at line 184.

> > Thanks for your report. > > Could you send me the output of the following commands? > > $ perl -MSys::Syslog -le 'print Sys::Syslog::_PATH_LOG()' > $ prove -bv t/syslog.t

-- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.

Tue Aug 29 07:13:52 2006 jdhedden [...] cpan.org - Correspondence added

From:

JDHEDDEN [...] cpan.org

Message body is not shown because it is too large.

Fri Nov 17 10:13:45 2006 jdhedden [...] cpan.org - Broken in 0.18 added

Wed Jun 20 16:44:15 2007 jdhedden [...] cpan.org - Correspondence added

Patch to fix this bug can be found at: http://rt.perl.org/rt3/Public/Bug/Display.html?id=43268

Wed Jun 20 19:33:12 2007 SAPER [...] cpan.org - Correspondence added

CC:	"Jerry D. Hedden" <jdhedden [...] cpan.org>, Reini Urban <rurban [...] x-ray.at>, Perl 5 Porters <perl5-porters [...] perl.org>
Subject:	Re: [rt.cpan.org #20635] 'make test' fails under Cygwin
Date:	Thu, 21 Jun 2007 01:32:41 +0200
To:	bug-Sys-Syslog [...] rt.cpan.org
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Reini Urban wrote: Show quoted text

> Attached patch fixes > ../ext/Sys/Syslog/t/syslog.t 1 256 159 1 136 > on cygwin without running syslog-ng > Apply to bleadperl. > > Without the syslog-ng daemon /dev/log and /dev/conslog are not > writable > in Sys::Syslog.pm:161 > > The patch detects for cygwin an installed syslog-ng binary (service > check within TAINT not possible) and fixes the checks.

Jerry D. Hedden wrote: Show quoted text

> Queue: Sys-Syslog > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=20635 > > > Patch to fix this bug can be found at: > http://rt.perl.org/rt3/Public/Bug/Display.html?id=43268

Thanks for the patch, but the next version of Sys::Syslog will simply skip the stream test under Cygwin because it has IMO no real meaning here, especially as the Unix native mechanism already works and as there will be a Win32 mechanism (using EventLog). -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.

Wed Jun 20 20:16:01 2007 rurban [...] x-ray.at - Correspondence added

CC:	bug-Sys-Syslog [...] rt.cpan.org, "Jerry D. Hedden" <jdhedden [...] cpan.org>, Perl 5 Porters <perl5-porters [...] perl.org>
Subject:	Re: [rt.cpan.org #20635] 'make test' fails under Cygwin
Date:	Thu, 21 Jun 2007 02:15:17 +0200
To:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>
From:	Reini Urban <rurban [...] x-ray.at>

Sébastien Aperghis-Tramoni schrieb: Show quoted text

> Reini Urban wrote:

>> Attached patch fixes >> ../ext/Sys/Syslog/t/syslog.t 1 256 159 1 136 >> on cygwin without running syslog-ng >> Apply to bleadperl. >> >> Without the syslog-ng daemon /dev/log and /dev/conslog are not writable >> in Sys::Syslog.pm:161 >> >> The patch detects for cygwin an installed syslog-ng binary (service >> check within TAINT not possible) and fixes the checks.

> > Jerry D. Hedden wrote: >

>> Queue: Sys-Syslog >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=20635 > >> >> Patch to fix this bug can be found at: >> http://rt.perl.org/rt3/Public/Bug/Display.html?id=43268

> > Thanks for the patch, but the next version of Sys::Syslog will simply > skip the stream test under Cygwin because it has IMO no real meaning > here, especially as the Unix native mechanism already works and as there > will be a Win32 mechanism (using EventLog).

Why? The /dev/log stream works fine in cygwin, same as under any Unix. You only have to use it. With a better error message people might install syslog-ng then. -- Reini

Wed Jun 20 20:49:36 2007 SAPER [...] cpan.org - Correspondence added

CC:	bug-Sys-Syslog [...] rt.cpan.org, "Jerry D. Hedden" <jdhedden [...] cpan.org>, Perl 5 Porters <perl5-porters [...] perl.org>
Subject:	Re: [rt.cpan.org #20635] 'make test' fails under Cygwin
Date:	Thu, 21 Jun 2007 02:49:16 +0200
To:	Reini Urban <rurban [...] x-ray.at>
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Reini Urban wrote: Show quoted text

>> Thanks for the patch, but the next version of Sys::Syslog will simply >> skip the stream test under Cygwin because it has IMO no real meaning >> here, especially as the Unix native mechanism already works and as >> there >> will be a Win32 mechanism (using EventLog).

> > Why? The /dev/log stream works fine in cygwin, same as under any Unix. > You only have to use it. > With a better error message people might install syslog-ng then.

Why not, but there is no need to install syslog-ng in order to use Sys::Syslog under Cygwin. It already converts native log events to Win32 events. If you execute "make test" and then open the events logger, you'll see a couple of entries in the Application journal. But ok, if you really want to, I'll apply your patch. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.

Wed Jul 25 20:14:01 2007 SAPER [...] cpan.org - Reference by ticket #28475 added

Fri Sep 07 09:46:30 2007 SAPER [...] cpan.org - Correspondence added

This issue has been resolved with Sys::Syslog 0.19 Thanks you both for reporting this bug and for your help. -- Close the world, txEn eht nepO.

Fri Sep 07 09:46:34 2007 SAPER [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Sep 07 09:47:02 2007 SAPER [...] cpan.org - Fixed in 0.19 added