Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 20611
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: thaljef [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 0.17
  • 0.18
Fixed in: 0.19



Subject: Problems parsing $VERSION
On Jul 6, 2006, at 9:10 AM, Joshua ben Jore wrote: Show quoted text
> I installed Perl::Critic on my bleadperl again and there were still a > whole raft of test failures. Just an FYI. I just included two > failures, there were 71 others but they all failed exactly the same > way. > > # Failed test in t/00_modules.t at line 31. > # got: '0.170' > # expected: '0.17' > > # Failed test 'Version of > Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations' > # in t/00_modules.t at line 97. > # got: '0.170' > # expected: '0.17' > > Josh
This is almost certainly a bad interaction between the new version.pm and the way Jeff evals the $VERSION. I think we should consider removing that eval for 1.0. I've never fully understood its purpose anyway. Chris
Fixed in version 0.19. We stripped out all the "eval $VERSION;" statements