Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Dependencies CPAN distribution.

Report information
The Basics
Id: 20543
Status: resolved
Priority: 0/
Queue: Test-Dependencies

People
Owner: Nobody in particular
Requestors: jjore [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.04
Fixed in: (no value)



Subject: ok_dependencies() in user module can't handle Test::Dependencies as a dependency
Class::Accessor::Named uses your sample script to validate that it's dependencies are there. Test::Dependencies is also listed as a prerequisite in it's Makefile.PL. It fails to notice that T::D itself is listed as a dependency. This causes C::A::N to fail its tests. ~/bin/perl/5.8.8/bin/prove -b -v t/01-dependencies.t t/01-dependencies....ok 1 - requires('Hook::LexWrap') in Makefile.PL ok 2 - requires('Sub::Name') in Makefile.PL ok 3 - requires('UNIVERSAL::require') in Makefile.PL not ok 4 - build_requires('Test::Dependencies') in Makefile.PL # Failed test 'build_requires('Test::Dependencies') in Makefile.PL' # in t/01-dependencies.t at line 5. not ok 5 - Test::Dependencies is not a dependency # Failed test 'Test::Dependencies is not a dependency' # in t/01-dependencies.t at line 5. 1..5 # Looks like you failed 2 tests of 5. dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 4-5 Failed 2/5 tests, 60.00% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/01-dependencies.t 2 512 5 2 40.00% 4-5 Failed 1/1 test scripts, 0.00% okay. 2/5 subtests failed, 60.00% okay. Here is the Module::Install using Makefile.PL: use inc::Module::Install; name ('Class-Accessor-Named'); author ('Jesse Vincent <jesse@bestpractical.com>'); version_from ('lib/Class/Accessor/Named.pm'); abstract_from('lib/Class/Accessor/Named.pm'); license('perl'); requires('Test::Dependencies'); requires('Hook::LexWrap'); requires('UNIVERSAL::require'); requires('Sub::Name'); auto_install(); &WriteAll;
Subject: Re: [rt.cpan.org #20543] ok_dependencies() in user module can't handle Test::Dependencies as a dependency
Date: Tue, 18 Jul 2006 19:06:42 -0400
To: bug-Test-Dependencies [...] rt.cpan.org
From: Zev Benjamin <zev [...] cpan.org>
Hi! Thanks for the bug report. The problem has been fixed in SVN and I have informed Jesse to push out a new distribution version. The problem was (arguably) not with Test::Dependencies. Note that there were two test failures: one saying that Test::Dependencies should have a build_requires line and the other saying that it is not a dependency. The second failing test output should probably be changed. It means that it is not a full dependency, but rather only a build-time one. I'll try to fix this later tonight. Zev via RT wrote: Show quoted text
> Tue Jul 18 18:17:18 2006: Request 20543 was acted upon. > Transaction: Ticket created by JJORE > Queue: Test-Dependencies > Subject: ok_dependencies() in user module can't handle Test::Dependencies > as a dependency > Broken in: 0.04 > Severity: (no value) > Owner: Nobody > Requestors: JJORE@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=20543 > > > > Class::Accessor::Named uses your sample script to validate that it's > dependencies are there. Test::Dependencies is also listed as a > prerequisite in it's Makefile.PL. It fails to notice that T::D itself is > listed as a dependency. This causes C::A::N to fail its tests. > > ~/bin/perl/5.8.8/bin/prove -b -v t/01-dependencies.t > t/01-dependencies....ok 1 - requires('Hook::LexWrap') in Makefile.PL > ok 2 - requires('Sub::Name') in Makefile.PL > ok 3 - requires('UNIVERSAL::require') in Makefile.PL > not ok 4 - build_requires('Test::Dependencies') in Makefile.PL > > # Failed test 'build_requires('Test::Dependencies') in Makefile.PL' > # in t/01-dependencies.t at line 5. > not ok 5 - Test::Dependencies is not a dependency > > # Failed test 'Test::Dependencies is not a dependency' > # in t/01-dependencies.t at line 5. > 1..5 > # Looks like you failed 2 tests of 5. > dubious > Test returned status 2 (wstat 512, 0x200) > DIED. FAILED tests 4-5 > Failed 2/5 tests, 60.00% okay > Failed Test Stat Wstat Total Fail Failed List of Failed > ------------------------------------------------------------------------------- > t/01-dependencies.t 2 512 5 2 40.00% 4-5 > Failed 1/1 test scripts, 0.00% okay. 2/5 subtests failed, 60.00% okay. > > Here is the Module::Install using Makefile.PL: > > use inc::Module::Install; > > name ('Class-Accessor-Named'); > author ('Jesse Vincent <jesse@bestpractical.com>'); > version_from ('lib/Class/Accessor/Named.pm'); > abstract_from('lib/Class/Accessor/Named.pm'); > license('perl'); > requires('Test::Dependencies'); > requires('Hook::LexWrap'); > requires('UNIVERSAL::require'); > requires('Sub::Name'); > auto_install(); > &WriteAll; > >
CC: JJORE [...] cpan.org
Subject: Re: [rt.cpan.org #20543] ok_dependencies() in user module can't handle Test::Dependencies as a dependency
Date: Tue, 18 Jul 2006 18:14:50 -0500
To: bug-Test-Dependencies [...] rt.cpan.org
From: "Joshua ben Jore" <twists [...] gmail.com>
On 7/18/06, zev@cpan.org via RT <bug-Test-Dependencies@rt.cpan.org> wrote: Show quoted text
Ok, thanks. You might also consider getting those test_pass() calls fixed too since they prevent Test::Dependencies from installing normally. Josh
Subject: Re: [rt.cpan.org #20543] ok_dependencies() in user module can't handle Test::Dependencies as a dependency
Date: Tue, 18 Jul 2006 19:16:03 -0400
To: bug-Test-Dependencies [...] rt.cpan.org
From: Zev Benjamin <zev [...] strangersgate.com>
Yep, I know about those, too ;). I happened to write the test code right before those functions were removed. That's also on my todo list for tonight. Zev Joshua ben Jore via RT wrote: Show quoted text
> Queue: Test-Dependencies > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=20543 > > > On 7/18/06, zev@cpan.org via RT <bug-Test-Dependencies@rt.cpan.org> wrote: > > Ok, thanks. You might also consider getting those test_pass() calls > fixed too since they prevent Test::Dependencies from installing > normally. > > Josh > >