| Subject: | Bug report and fix for Net-UPS-0.04 |
| Date: | Tue, 18 Jul 2006 13:09:26 -0700 |
| To: | sherzodr [...] cpan.org, bug-Net-UPS [...] rt.cpan.org |
| From: | Christian Marcotte <scoob [...] mindinmotiontech.com> |
Hi there.
A while back I gave you a patch for Net-UPS-0.04 to fix the
routine is_oversize (found in Package.pm).
I'm afraid there as a bug in the code.
I was sorting the sides of the box using regular sort which is
is NOT a numerical sort...
Here is the fix.
File: UPS/Package.pm
Routine: is_oversized
Original line:
my @sides = sort {$a <=> $b} ($self->length, $self->width, self->height);
CORRECT LINE:
# sort numerically ascending
my @sides = sort {$a <=> $b} ($self->length, $self->width, $self->height);
Thanks again for a great module!
-- Christian
------------------------------------------------------------------
Christian Marcotte Mind In Motion Technology
Chief Technologist scoob@MindInMotionTech.com
(831) 621-3788
By honoring others, you are not doing a favor
to others but to yourself.
- Swami Muktananda