Skip Menu |

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 20447
Status: resolved
Priority: 0/
Queue: DBD-Pg

People
Owner: Nobody in particular
Requestors: ianburrell [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.49
Fixed in: 2.0.0



Subject: Different in getline function removing new lines
The behavior of getline is different depending on if the old PQgetline or new PGgetCopyData functions are used. The old interface removed the "\n" at the end of the line. The new interface leaves the "\n" at the end. This is a regression between old versions of DBD::Pg. And will be different when old versions of libpq are used with DBD::Pg 1.49.
On Thu Jul 13 14:52:08 2006, ianburrell@gmail.com wrote: Show quoted text
> The behavior of getline is different depending on if the old PQgetline > or new PGgetCopyData functions are used. The old interface removed the > "\n" at the end of the line. The new interface leaves the "\n" at the
end. Show quoted text
> > This is a regression between old versions of DBD::Pg. And will be > different when old versions of libpq are used with DBD::Pg 1.49.
To make it clear, we like the new interface where it leaves the "\n" on the end. It the fact that the interface changed which is the problem. At the very least DBD::Pg->pg_getline should behave the same no matter what internal pg function it uses.
FWIW, DBD::Pg will no longer compile against 7.3 or earlier libraries, so PQgetCopyData will be the standard. Agreed that we should have been more careful in the transition.
2.0.0 has the new API in place.