Bug #204 for Net-Telnet: [Patch] test 3 failure

Thu Jan 24 21:31:53 2002 Guest - Ticket created

Subject:

[Patch] test 3 failure

Hello, I had test failures with Net::Telnet. Found what I'm pretty sure is an error in test three. If tests 1 and 2 succeed, select should have found one live handle. Patch attached. Tom

--- Net-Telnet-3.02/t/select.t.orig Thu Jun 10 10:25:52 1999 +++ Net-Telnet-3.02/t/select.t Thu Jan 24 04:37:39 2002 @@ -22,7 +22,7 @@ test ($@ eq ""); ## Did select() return a correct value? - test (defined($nfound) and $nfound == 0); + test (defined($nfound) and $nfound == 1); exit; } # end main program

Mon Jun 17 20:07:45 2002 Guest - Correspondence added

From:

clintdw [...] netcom.com

The results for test 3 is different between linux kernel 2.2.x and 2.4.x. On linux 2.2.x kernels, test 3 passes. On 2.2.4, it fails. The test checks to see if a newly created socket has anything to read, with the expected results being "no." I think the 2.2 kernel is doing the right thing and the 2.4 kernel is not. However, I think test 3 could be updated to actually do a bind() and listen() after socket(). After that, the test passes on both 2.2.x and 2.4.x kernels. It isn't really clear to me that one can call select() on a generic socket without turning it into a server socket or client socket. [guest - Thu Jan 24 21:31:53 2002]: Show quoted text

> Hello, > I had test failures with Net::Telnet. Found what I'm pretty sure is an > error in test three. > > If tests 1 and 2 succeed, select should have found one live handle. > Patch attached. > > Tom

Tue Oct 28 11:14:27 2003 jay [...] rgrs.com - Status changed from 'new' to 'open'

Tue Oct 28 11:15:10 2003 jay [...] rgrs.com - Status changed from 'open' to 'resolved'

Tue Oct 28 11:15:11 2003 jay [...] rgrs.com - Fixed in 3.03 added

Sat Dec 15 22:27:22 2012 jay [...] rgrs.com - Fixed in 3.03 added