Skip Menu |

This queue is for tickets about the Text-NSP CPAN distribution.

Report information
The Basics
Id: 20371
Status: resolved
Priority: 0/
Queue: Text-NSP

People
Owner: Nobody in particular
Requestors: sean [...] semanticbible.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.01
Fixed in: (no value)



Subject: MakeMaker postamble breaks under nmake/Windows
Module: Text-NSP-1.01 Perl 5.8.8 CYGWIN_NT-5.1 (Windows XP) When installing under Windows using nmake 1.5, nmake dies on the '@echo' statement in the postamble. Example: --------------- c:\Perl\site\lib\Text\NSP\Text-NSP-1.01>nmake nmake Microsoft (R) Program Maintenance Utility Version 1.50 Copyright (c) Microsoft Corp 1988-94. All rights reserved. makefile(1199) : fatal error U1033: syntax error : '@echo' unexpected Stop. --------------- Workaround: if you change Makefile.pl so MY::postamble just returns an empty string, it installs okay (but then of course you don't get the helpful message it was designed to deliver). I've attached Makefile2.pl which is how i got around it.
Subject: Makefile2.pl
use 5.008005; use ExtUtils::MakeMaker; my @utils_to_install = qw (kocos.pl rank.pl combig.pl huge-count.pl huge-combine.pl sort-bigrams.pl split-data.pl); my @required_to_install = qw(count.pl statistic.pl); my @sh_to_install = qw( kocos-script.sh rank-script.sh combig-script.sh ); WriteMakefile( NAME => 'Text::NSP', VERSION_FROM => 'lib/Text/NSP.pm', # finds $VERSION PREREQ_PM => {}, CONFIGURE => \&configSub, EXE_FILES => [ map ("bin/$_", @required_to_install), map ("bin/utils/$_", @utils_to_install), map ("bin/utils/$_", @sh_to_install), ], ($] >= 5.005 ? ## Add these new keywords supported since 5.005 (ABSTRACT_FROM => 'lib/Text/NSP.pm', # retrieve abstract from module AUTHOR => 'Ted Pedersen <tpederse@d.umn.edu>') : ()), ); sub configSub { print "#################################################################\n"; print " You are running Makefile.PL. When this finishes, remember that you\n"; print " will also need to run the following to finish the install of NSP:\n"; print "\n"; print " make\n"; print " make test\n"; print " make install\n"; print "\n"; print " if \"make install\" fails and indicates that you don\'t have proper\n"; print " permissions to install, you do have the option to install NSP in\n"; print " a local directory of your own choosing. You can do this as follows:\n"; print "\n"; print " perl Makefile.PL PREFIX=/MYDIR/NSP\n"; print " make\n"; print " make test\n"; print " make install\n"; print "\n"; print " where /MYDIR is a directory that you own and can write to, and\n"; print " NSP is a new subdirectory. (The name NSP is not required, it\n"; print " can be anything)\n"; print "\n"; print " After all this is done, you can run \"make clean\" to remove some\n"; print " of the files created during installation\n"; print "#################################################################\n"; return {}; } sub MY::postamble { my $postamble = ""; # my $postamble = <<'END'; # html: # @echo "*****************************************************" # @echo "Installing the Ngram Statistics Package, V $(VERSION)..." # @echo " ...into $(SITEPREFIX) (/doc /bin /lib /man) " # @echo "Make sure that the following are in your PATH:" # @echo " $(INSTALLBIN)" # @echo "and the following in your PERL5LIB:" # @echo " $(INSTALLSITELIB)" # @echo "*****************************************************" # END return ($postamble); } sub MY::install { my $self = shift; my $string = $self->MM::install; my $add = 'html'; $string =~ s/(pure_install\s+)(.*)/$1 $add $2/; return $string; } # For testing sub MY::test { q( TEST_VERBOSE=0 test: all $(FULLPERL) t/TEST $(TEST_VERBOSE) ); }
Thanks for this information, as well as for the revised makefile. Text-NSP is in a kind of steady state now, so we aren't making many changes, but a small clean up version (1.05) is in the works, and I'll make sure to include this as a part of it. Cordially, Ted On Sat Jul 08 20:30:02 2006, guest wrote: Show quoted text
> Module: Text-NSP-1.01 > Perl 5.8.8 > CYGWIN_NT-5.1 (Windows XP) > > When installing under Windows using nmake 1.5, nmake dies on the '@echo' > statement in the postamble. Example: > --------------- > c:\Perl\site\lib\Text\NSP\Text-NSP-1.01>nmake > nmake > > Microsoft (R) Program Maintenance Utility Version 1.50 > Copyright (c) Microsoft Corp 1988-94. All rights reserved. > > makefile(1199) : fatal error U1033: syntax error : '@echo' unexpected > Stop. > --------------- > Workaround: if you change Makefile.pl so MY::postamble just returns an > empty string, it installs okay (but then of course you don't get the > helpful message it was designed to deliver). I've attached Makefile2.pl > which is how i got around it. >
We had another report from a windows user that the blank line before the @echo statement was causing some problems, and so we removed the blank in this version. We did however want to keep our descriptive messages, given that some of our users are not experience with Perl or CPAN modules. So, we think that removing the blank line may have resolved this, although we aren't sure since we aren't able to test on Windows too easily. So, we'd be interested to hear if this has been resolved in 1.05, as we hope it has. Thanks! Ted On Wed Mar 19 14:07:29 2008, TPEDERSE wrote: Show quoted text
> Thanks for this information, as well as for the revised makefile. > Text-NSP is in a kind of steady state now, so we aren't making many > changes, but a small clean up version (1.05) is in the works, and I'll > make sure to include this as a part of it. > > Cordially, > Ted > > On Sat Jul 08 20:30:02 2006, guest wrote:
> > Module: Text-NSP-1.01 > > Perl 5.8.8 > > CYGWIN_NT-5.1 (Windows XP) > > > > When installing under Windows using nmake 1.5, nmake dies on the '@echo' > > statement in the postamble. Example: > > --------------- > > c:\Perl\site\lib\Text\NSP\Text-NSP-1.01>nmake > > nmake > > > > Microsoft (R) Program Maintenance Utility Version 1.50 > > Copyright (c) Microsoft Corp 1988-94. All rights reserved. > > > > makefile(1199) : fatal error U1033: syntax error : '@echo' unexpected > > Stop. > > --------------- > > Workaround: if you change Makefile.pl so MY::postamble just returns an > > empty string, it installs okay (but then of course you don't get the > > helpful message it was designed to deliver). I've attached Makefile2.pl > > which is how i got around it. > >
> >
Subject: RE: [rt.cpan.org #20371] MakeMaker postamble breaks under nmake/Windows
Date: Fri, 21 Mar 2008 08:01:18 -0700
To: <bug-Text-NSP [...] rt.cpan.org>
From: "Sean Boisen" <sean.boisen [...] gmail.com>
Ted: I'm not actively using NSP (or even Perl) now, so I won't be testing the new version, but I'm glad the information was helpful. Sean Show quoted text
-----Original Message----- From: TPEDERSE via RT [mailto:bug-Text-NSP@rt.cpan.org] Sent: Thursday, March 20, 2008 3:00 PM To: sean@semanticbible.com Subject: [rt.cpan.org #20371] MakeMaker postamble breaks under nmake/Windows <URL: http://rt.cpan.org/Ticket/Display.html?id=20371 > We had another report from a windows user that the blank line before the @echo statement was causing some problems, and so we removed the blank in this version. We did however want to keep our descriptive messages, given that some of our users are not experience with Perl or CPAN modules. So, we think that removing the blank line may have resolved this, although we aren't sure since we aren't able to test on Windows too easily. So, we'd be interested to hear if this has been resolved in 1.05, as we hope it has. Thanks! Ted On Wed Mar 19 14:07:29 2008, TPEDERSE wrote:
> Thanks for this information, as well as for the revised makefile. > Text-NSP is in a kind of steady state now, so we aren't making many > changes, but a small clean up version (1.05) is in the works, and I'll > make sure to include this as a part of it. > > Cordially, > Ted > > On Sat Jul 08 20:30:02 2006, guest wrote:
> > Module: Text-NSP-1.01 > > Perl 5.8.8 > > CYGWIN_NT-5.1 (Windows XP) > > > > When installing under Windows using nmake 1.5, nmake dies on the '@echo' > > statement in the postamble. Example: > > --------------- > > c:\Perl\site\lib\Text\NSP\Text-NSP-1.01>nmake > > nmake > > > > Microsoft (R) Program Maintenance Utility Version 1.50 > > Copyright (c) Microsoft Corp 1988-94. All rights reserved. > > > > makefile(1199) : fatal error U1033: syntax error : '@echo' unexpected > > Stop. > > --------------- > > Workaround: if you change Makefile.pl so MY::postamble just returns an > > empty string, it installs okay (but then of course you don't get the > > helpful message it was designed to deliver). I've attached Makefile2.pl > > which is how i got around it. > >
> >
At long last it appears we install on Windows with no problems. This is true as of version 1.09. We have made our installation process more standardized as was suggested we should in this and other bug reports. Thanks! Ted