Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 20254
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: thaljef [...] cpan.org
Requestors: ANDREWF [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.17
Fixed in: 0.18
Attachments
perl-critic-patch

History Show all quoted text
  Mon Jul 03 05:03:15 2006 ANDREWF [...] cpan.org - Ticket created
Subject: use vars qw(@EXPORT_OK ) not recognized
The test for "use vars qw(@EXPORT)" in sub _vars_EXPORT() in lib/Perl/Critic/Policy/Modules/ProhibitAutomaticExportation.pm is broken; it checks against the regexp "m{ \@EXPORT }mx", but that matches @EXPORT_OK, which is valid. The attached patch matches against "m{ \@EXPORT\b }mx" and adds another test case to t/20_policies_modules.t
Subject: perl-critic-patch
Download perl-critic-patch
application/octet-stream 1.3k

Message body not shown because it is not plain text.

  Wed Jul 05 01:09:00 2006 thaljef [...] cpan.org - Correspondence added
Thanks for the excellent patch. I'll put this in the next release. -Jeff
  Wed Jul 05 01:09:01 2006 The RT System itself - Status changed from 'new' to 'open'
  Wed Jul 05 01:09:02 2006 thaljef [...] cpan.org - Given to THALJEF
  Mon Jul 17 13:32:08 2006 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Jul 17 13:32:09 2006 thaljef [...] cpan.org - Fixed in 0.18 added