Bug #20231 for YAML-Syck: patch for broken win32 compile in 0.61

Sun Jul 02 03:34:36 2006 Guest - Ticket created

Subject:

patch for broken win32 compile in 0.61

MS compiler needs variable declarations at the top of a function

Subject:

perl_syck.h.diff

--- C:\src\cpan\build\YAML-Syck-0.61\perl_syck.h Sun Jul 02 00:01:44 2006 +++ C:\src\cpan\build\YAML-Syck-0.61\perl_syck.h Sun Jul 02 17:22:13 2006 @@ -184,6 +184,7 @@ } else if (load_code && (strEQ(id, "perl/code") || strnEQ(id, "perl/code:", 10))) { SV *cv; SV *text, *sub; + char *pkg; /* This code is copypasted from Storable.xs */ @@ -210,7 +211,7 @@ croak("code %s did not evaluate to a subroutine reference\n", SvPV_nolen(sub)); } - char *pkg = id + 10; + pkg = id + 10; if ( *pkg != '\0' ) { sv_bless(sv, gv_stashpv(pkg, TRUE)); } @@ -296,10 +297,12 @@ SV* key = perl_syck_lookup_sym(p, syck_map_read(n, map_key, 0)); SV* val = perl_syck_lookup_sym(p, syck_map_read(n, map_value, 0)); + char *ref_type; + sv = newRV_noinc(val); USE_OBJECT(val); - char *ref_type = SvPVX(key); + ref_type = SvPVX(key); if (strnNE(ref_type, REF_LITERAL, REF_LITERAL_LENGTH+1)) { /* handle the weird audrey scalar ref stuff */ sv_bless(sv, gv_stashpv(ref_type, TRUE));

Thu May 20 07:41:56 2010 avar [...] cpan.org - Correspondence added

On Sun Jul 02 03:34:36 2006, guest wrote: Show quoted text

> MS compiler needs variable declarations at the top of a function

Still an issue? (This is a form-reply that isn't specific to your particular report) YAML::Syck has just acquired one new maintainer (me), it still doesn't have anyone that *cares* about it. But I'm willing to help solve your report & release a new version with the fix if it's easy for me. It now has a Git repository at: http://github.com/avar/YAML-Syck If your report is a patch that fixes a problem, great. Please remake the patch against Git by forking that repo and sending me a pull request on GitHub (or an update to this bug if you prefer git-format-patch(1) or some other repo provider..). Make sure to include a test for what you fixed. If your report is some code that fails (and you have a testcase for it) a patch against the test suite to demonstrate that failure would be very useful. It's OK if the test crashes and burns, see Test::More's docs for how to make TODO tests that fail now, but shouldn't. Even if it segfaults perl C<system $^X => qw/ -Mblib -MYAML::Syck .../> or something like that and checking the return value will do.

Thu May 20 07:41:57 2010 The RT System itself - Status changed from 'new' to 'open'

Thu May 20 07:41:58 2010 avar [...] cpan.org - Status changed from 'open' to 'stalled'

Sat May 22 21:00:16 2010 masterfuol [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #20231] patch for broken win32 compile in 0.61
Date:	Sun, 23 May 2010 02:00:07 +0100
To:	bug-YAML-Syck [...] rt.cpan.org
From:	Andrew <masterfuol [...] gmail.com>

Looks like this has been resolved - thanks for the followup. On Thu, May 20, 2010 at 12:41 PM, AEvar Arnfjord Bjarmason via RT < bug-YAML-Syck@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=20231 > > > On Sun Jul 02 03:34:36 2006, guest wrote:

> > MS compiler needs variable declarations at the top of a function

> > Still an issue? > > (This is a form-reply that isn't specific to your particular report) > > YAML::Syck has just acquired one new maintainer (me), it still doesn't > have anyone that *cares* about it. But I'm willing to help solve your > report & release a new version with the fix if it's easy for me. > > It now has a Git repository at: > > http://github.com/avar/YAML-Syck > > If your report is a patch that fixes a problem, great. Please remake > the patch against Git by forking that repo and sending me a pull > request on GitHub (or an update to this bug if you prefer > git-format-patch(1) or some other repo provider..). Make sure to > include a test for what you fixed. > > If your report is some code that fails (and you have a testcase for > it) a patch against the test suite to demonstrate that failure would > be very useful. It's OK if the test crashes and burns, see > Test::More's docs for how to make TODO tests that fail now, but > shouldn't. Even if it segfaults perl C<system $^X => qw/ -Mblib > -MYAML::Syck .../> or something like that and checking the return > value will do. >

Sat May 22 21:00:18 2010 The RT System itself - Status changed from 'stalled' to 'open'

Sun May 23 08:33:52 2010 avar [...] cpan.org - Correspondence added

On Sun Jul 02 03:34:36 2006, guest wrote: Show quoted text

> MS compiler needs variable declarations at the top of a function

fixed, evidently.

Sun May 23 08:33:57 2010 avar [...] cpan.org - Status changed from 'open' to 'resolved'