Bug #20164 for Sys-Syslog: connect_unix() breaks if setlogsock is called first

Wed Jun 28 09:19:55 2006 Guest - Ticket created

Subject:

connect_unix() breaks if setlogsock is called first

Hi, in Sys::Syslog 0.16, syslog() is failing with no connection to syslog available - _PATH_LOG not available in syslog.h at /home/niko/t.pl line 5 if setlogsock('unix') is called first. Sample program: #!/usr/bin/perl -w use Sys::Syslog qw(:DEFAULT setlogsock); setlogsock('unix'); openlog("test", 'pid', 'local0'); syslog('local0|info', "test"); This happens because the test at the beginning of connect_unix() isn't prepared for the case where $syslog_path is already defined. Proposed patch attached. I have verified this on perl 5.8.8, on Debian GNU/Linux. Cheers, -- Niko Tyni ntyni@iki.fi

Subject:

syslog-patch

Download syslog-patch
application/octet-stream 340b

Message body not shown because it is not plain text.

Wed Jun 28 10:23:04 2006 SAPER [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #20164] connect_unix() breaks if setlogsock is called first
Date:	Wed, 28 Jun 2006 16:22:44 +0200
To:	bug-Sys-Syslog [...] rt.cpan.org
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Show quoted text

> in Sys::Syslog 0.16, syslog() is failing [...] if setlogsock('unix') > is called first. > > This happens because the test at the beginning of connect_unix() isn't > prepared for the case where $syslog_path is already defined.

This is indeed a bug that was added with version 0.16. Show quoted text

> Proposed patch attached.

Thanks. It will be included in the next release. -- Sébastien Aperghis-Tramoni Close the world, txEn eht nepO.

Wed Jun 28 10:23:05 2006 The RT System itself - Status changed from 'new' to 'open'

Wed Jun 28 11:14:55 2006 SAPER [...] cpan.org - Taken

Tue Jul 18 22:13:02 2006 GIRAFFED [...] cpan.org - Correspondence added

From:

GIRAFFED [...] cpan.org

The message would be more accurate as, "_PATH_LOG not available in syslog.h and you didn't specify a log socket name with setlogsock()." I.e. _PATH_LOG isn't actually required.

Thu Jul 20 21:13:57 2006 SAPER [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #20164] connect_unix() breaks if setlogsock is called first
Date:	Fri, 21 Jul 2006 03:13:41 +0200
To:	bug-Sys-Syslog [...] rt.cpan.org
From:	Sébastien Aperghis-Tramoni <saper [...] cpan.org>

Show quoted text

> The message would be more accurate as, "_PATH_LOG not available in > syslog.h and you didn't specify a log socket name with setlogsock()." > > I.e. _PATH_LOG isn't actually required.

Correct. Thanks for noting. Sébastien Aperghis-Tramoni -- - --- -- - -- - --- -- - --- -- - --[ http://maddingue.org ] Close the world, txEn eht nepO

Sun Jul 23 14:42:35 2006 SAPER [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jul 23 14:42:36 2006 SAPER [...] cpan.org - Fixed in 0.17 added