Skip Menu |

This queue is for tickets about the IPC-Run CPAN distribution.

Report information
The Basics
Id: 20105
Status: resolved
Priority: 0/
Queue: IPC-Run

People
Owner: TODDR [...] cpan.org
Requestors: andrew.benham [...] thus.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 0.80
  • 0.80_91
  • 0.91
Fixed in: (no value)



Subject: t/pty.t fails on Solaris 10
Perl 5.8.4, IO-Tty 1.05 Both Solaris 10 sparc and Solaris 10 x86. Some of the tests are failing, showing strings with "<CR><CR><LF>" as the line ending. I can work around these by changing '\r?' to '\r*'. But some tests see too many 'hello's.
Subject: OUT
Download OUT
application/octet-stream 10.4k

Message body not shown because it is not plain text.

I see the same problem, Solaris 10 (Sparc), Perl 5.8.4, IPC::Run 0.82 t/pty..............# IO::Tty 1.08, IO::Pty 1.08 t/pty..............ok 9/32# Failed test (t/pty.t at line 147) t/pty..............NOK 10# got: 'HELLO # hello # ' # expected: '(?i-xsm:^(?:hello\r?\n){2}(?!\n)$)' t/pty..............ok 11/32# Failed test (t/pty.t at line 153) t/pty..............NOK 12# got: 'HELLO # hello # WORLD # world # ' # expected: '(?i-xsm:^(?:hello\r?\n){2}(?:world\r?\n){2}(?!\n)$)' t/pty..............ok 16/32# Failed test (t/pty.t at line 170) t/pty..............NOK 17# got: 'hello # ' # expected: '(?-xism:^hello\r?\n(?!\n)$)' t/pty..............ok 19/32# Failed test (t/pty.t at line 178) # got: 'hello # world # ' t/pty..............NOK 20# expected: '(?-xism:^hello\r?\nworld\r?\n(?!\n)$)' t/pty..............ok 25/32# Failed test (t/pty.t at line 198) t/pty..............NOK 26# got: 'hello # hello # HELLO # hello # ' # expected: '(?i-xsm:^(?:hello\r?\n){3}(?!\n)$)' t/pty..............ok 27/32# Failed test (t/pty.t at line 204) t/pty..............NOK 28# got: 'hello # hello # HELLO # hello # world # world # WORLD # world # ' # expected: '(?i-xsm:^(?:hello\r?\n){3}(?:world\r?\n){3}(?!\n)$)' t/pty..............ok 32/32# Looks like you failed 6 tests of 32. t/pty..............dubious Test returned status 6 (wstat 1536, 0x600) DIED. FAILED tests 10, 12, 17, 20, 26, 28 Failed 6/32 tests, 81.25% okay
I also have failures of some of these tests, on a Linux 64 bit system, using the latest SVN version of IPC::Run. The failures occur maybe 20% of the time and does not always affect the same test. t/pty.t ...................... # IO::Tty 1.08, IO::Pty 1.08 t/pty.t ...................... 1/32 # Failed test at t/pty.t line 170. # got: 'hello' # expected: '(?^:^hello\r?\n(?!\n)$)' # Failed test at t/pty.t line 178. # got: 'hello # world' # expected: '(?^:^hello\r?\nworld\r?\n(?!\n)$)' # Looks like you failed 2 tests of 32. t/pty.t ...................... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/32 subtests Or also: t/pty.t ...................... # IO::Tty 1.08, IO::Pty 1.08 t/pty.t ...................... 1/32 # Failed test at t/pty.t line 204. # got: 'hello # HELLO # hello # world # WORLD # world' # expected: '(?^i:^(?:hello\r?\n){3}(?:world\r?\n){3}(?!\n)$)' # Looks like you failed 1 test of 32. t/pty.t ...................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/32 subtests
The problem is still present with IO::Pty version 1.10
Subject: t/pty.t fails on Solaris 10 (and linux)
Looking at the strace output of a t/pty.t run on Debian/wheezy it seems that the read() system call only get "hello", but the pump() calls expect "hello\n" (or "hello\r\n"). Here's a patch which fixes the regexps used in the pump() calls: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/IPC-Run-0.92-RT20105.patch Regards, Slaven
On 2013-12-28 05:35:48, SREZIC wrote: Show quoted text
> Looking at the strace output of a t/pty.t run on Debian/wheezy it > seems that the read() system call only get "hello", but the pump() > calls expect "hello\n" (or "hello\r\n"). Here's a patch which fixes > the regexps used in the pump() calls: > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/IPC-Run- > 0.92-RT20105.patch
Unfortunately this help does not fix the Solaris problems. For some reason, the read() system call would get a double "\r" here: H E L L O\r\r\n h e l l o\r\r\n So all pump() calls and test regexps would have to be changed from matching \r? to \r*. Still with this change there are two further test failures... Regards, Slaven
Subject: [rt.cpan.org #20105]
Date: Mon, 05 May 2014 17:22:04 +0200
To: bug-IPC-Run [...] rt.cpan.org
From: Normand <normand [...] linux.vnet.ibm.com>
The IPC-Run-0.92-RT20105.patch suggested at https://rt.cpan.org/Public/Bug/Display.html?id=20105#txn-1306043 is a required patch for ppc64le architecture. -- Michel Normand
On 2013-12-28 05:35:48, SREZIC wrote: Show quoted text
> Looking at the strace output of a t/pty.t run on Debian/wheezy it > seems that the read() system call only get "hello", but the pump() > calls expect "hello\n" (or "hello\r\n"). Here's a patch which fixes > the regexps used in the pump() calls: > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/IPC-Run- > 0.92-RT20105.patch
Problem still exists with 0.93.
On Thu Dec 11 01:48:07 2014, SREZIC wrote: Show quoted text
> On 2013-12-28 05:35:48, SREZIC wrote:
> > Looking at the strace output of a t/pty.t run on Debian/wheezy it > > seems that the read() system call only get "hello", but the pump() > > calls expect "hello\n" (or "hello\r\n"). Here's a patch which fixes > > the regexps used in the pump() calls: > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/IPC-Run- > > 0.92-RT20105.patch
> > Problem still exists with 0.93.
Sorry, I missed this patch because it wasn't on github. It's 2am. I'll take a look at it tomorrow.
On Thu Dec 11 01:48:07 2014, SREZIC wrote: Show quoted text
> On 2013-12-28 05:35:48, SREZIC wrote:
> > Looking at the strace output of a t/pty.t run on Debian/wheezy it > > seems that the read() system call only get "hello", but the pump() > > calls expect "hello\n" (or "hello\r\n"). Here's a patch which fixes > > the regexps used in the pump() calls: > > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/IPC-Run- > > 0.92-RT20105.patch
> > Problem still exists with 0.93.
I put 0.93_01 out tonight. I'll bump to 0.94 in a day or 2 assuming it clears CPAN.
Now on CPAN as 0.94