Bug #19815 for Archive-Extract: make test fail under Cygwin

Sat Jun 10 12:35:22 2006 Guest - Ticket created

Subject:

make test fail under Cygwin

Cygwin on WinXP SP2. perl 5.8.7 $ make test /usr/local/bin/perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_Archive-Extract....ok 242/0No root path(s) specified at t/01_Archive-Extract.t line 234 eval {...} called at t/01_Archive-Extract.t line 234 Use of uninitialized value in -d at t/01_Archive-Extract.t line 236. No root path(s) specified at t/01_Archive-Extract.t line 234 eval {...} called at t/01_Archive-Extract.t line 234 Use of uninitialized value in -d at t/01_Archive-Extract.t line 236. No root path(s) specified at t/01_Archive-Extract.t line 234 eval {...} called at t/01_Archive-Extract.t line 234 Use of uninitialized value in -d at t/01_Archive-Extract.t line 236. No root path(s) specified at t/01_Archive-Extract.t line 234 eval {...} called at t/01_Archive-Extract.t line 234 Use of uninitialized value in -d at t/01_Archive-Extract.t line 236. Can't use an undefined value as an ARRAY reference at ../lib/Archive/Extract.pm line 742. # Looks like your test died just after 377. Detailed log with "perl -Ilib t/01_Archive-Extract.t > ae.out 2>&1" is attached.

Subject:

ae.out

Download ae.out
application/octet-stream 25.4k

Message body not shown because it is not plain text.

Wed Aug 02 07:13:58 2006 kane [...] cpan.org - Correspondence added

On Sat Jun 10 12:35:22 2006, guest wrote: Show quoted text

> Cygwin on WinXP SP2. > perl 5.8.7

Greetings, I've not been able to reproduce the errors you encountered, but i've added sanity checks in the code that should prevent this situation from arrising. I'm uploading Archive::Extract 0.11_01 to the CPAN now, which has this code in it to specifically avoid the test failures you are getting. If you could try out that release and get back to me, that would be much appreciated. -- Jos

Wed Aug 02 07:14:01 2006 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 02 07:14:03 2006 kane [...] cpan.org - Status changed from 'open' to 'stalled'

Thu Aug 03 05:57:53 2006 alexchorny [...] gmail.com - Correspondence added

From:

alexchorny [...] gmail.com

On Aug 02 07:13:58 2006, KANE wrote: Show quoted text

> If you could try out that release and get back to me, that would be > much appreciated.

Test awaits input after test 409. Prefers 'y' or 'n'. ok 400 - extract() for 'double_dir.zip' reports success ok 401 # skip No buffers available ok 402 # skip No buffers available ok 403 # skip No buffers available ok 404 # skip No buffers available ok 405 # skip No buffers available ok 406 # skip No buffers available ok 407 - Output file successfully removed ok 408 # skip No extract patch captured, can't remove paths ok 409 # skip No extract patch captured, can't remove paths At this point exists: out/x/y/z,out/y/ With this all tests path. I have "UnZip 5.50 of 17 February 2002, by Info-ZIP. Maintained by C. Spieler." in Cygwin. Attempt to duplicate test behaviour: $ unzip -Z -1 double_dir.zip x/y/z x/w $ unzip -qq double_dir.zip replace x/y/z? [y]es, [n]o, [A]ll, [N]one, [r]ename: P.S. String "No extract patch captured, can't remove paths" contains word "patch". Should it be "path"?

Thu Aug 03 05:57:54 2006 The RT System itself - Status changed from 'stalled' to 'open'

Thu Aug 03 08:17:35 2006 kane [...] cpan.org - Correspondence added

On Thu Aug 03 05:57:53 2006, alexchorny@gmail.com wrote: Show quoted text

> On Aug 02 07:13:58 2006, KANE wrote:

> > If you could try out that release and get back to me, that would be > > much appreciated.

> > > Test awaits input after test 409. Prefers 'y' or 'n'.

[...] Show quoted text

> $ unzip -qq double_dir.zip > replace x/y/z? [y]es, [n]o, [A]ll, [N]one, [r]ename:

I didn't encounter this problem, but according to 'man unzip' adding a -o flag overwrites the files if they exist already. I've added this option to unzip now. release 0.11_02, on CPAN shortly, will have this fix. If you could test it and get back to me, it'd be much appreciated. Show quoted text

> > P.S. String "No extract patch captured, can't remove paths" contains > word "patch". Should it be "path"?

Yes it should :) A bit to much patching lately i guess :) THanks for reporting, -- Jos

Thu Aug 03 08:17:36 2006 kane [...] cpan.org - Status changed from 'open' to 'stalled'

Thu Aug 03 15:40:50 2006 alexchorny [...] gmail.com - Correspondence added

From:

Alexandr Ciornii <alexchorny [...] gmail.com>

On Aug 03 08:17:35 2006, KANE wrote: Show quoted text

> I didn't encounter this problem, but according to 'man unzip' adding a > -o > flag overwrites the files if they exist already. I've added this > option to unzip > now. release 0.11_02, on CPAN shortly, will have this fix. > > If you could test it and get back to me, it'd be much appreciated.

Works. But there are too many warnings in test. Maybe there is a way to reduce them? ------- Alexandr Ciornii, http://chorny.net

Thu Aug 03 15:40:51 2006 The RT System itself - Status changed from 'stalled' to 'open'

Thu Aug 03 17:28:20 2006 kane [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #19815] make test fail under Cygwin
Date:	Thu, 3 Aug 2006 23:28:06 +0200 (CEST)
To:	bug-Archive-Extract [...] rt.cpan.org
From:	kane [...] xs4all.nl

Show quoted text

> Works. > But there are too many warnings in test. Maybe there is a way to reduce > them?

Can you show me a lot with what warnings come by please?

Fri Aug 04 05:01:50 2006 alexchorny [...] gmail.com - Correspondence added

From:

alexchorny [...] gmail.com

On Aug 03 17:28:20 2006, kane@xs4all.nl wrote: Show quoted text

> > But there are too many warnings in test. Maybe there is a way to

reduce them? Show quoted text

> Can you show me a lot with what warnings come by please?

Attached results of test run with TEST_VERBOSE=1 under Cygwin. There are around 130 warnings. Tried also with latest PathTools. ------- Alexandr Ciornii, http://chorny.net

Download 01_Archive-Extract.t.out
application/octet-stream 42.2k

Message body not shown because it is not plain text.

Wed Aug 09 08:30:35 2006 kane [...] cpan.org - Correspondence added

Hi, Show quoted text

> > Can you show me a lot with what warnings come by please?

> > Attached results of test run with TEST_VERBOSE=1 under Cygwin. > There are around 130 warnings. > Tried also with latest PathTools.

I've tracked one of the warnings down to a section in the testing code (that's the Module::Load::Conditional) one. The file::spec warning though i can't quite track down, but i *think* it's an issue wiht Archive::Zip. Some versions seems to spew warnings like this on some OS under some condition: ### uninitialized value in File::Spec warnings come from A::Zip: # t/01_Archive-Extract....ok 135/0Use of uninitialized value in concatenation (.) or string at / opt/lib/perl5/5.8.3/File/Spec/Unix.pm line 313. # File::Spec::Unix::catpath('File::Spec','','','undef') called at /opt/lib/perl5/site_perl/ 5.8.3/Archive/Zip.pm line 473 # Archive::Zip::_asLocalName('') called at /opt/lib/perl5/site_perl/5.8.3/Archive/Zip.pm line 652 # Archive::Zip::Archive::extractMember('Archive::Zip::Archive=HASH (0x9679c8)','Archive::Zip::ZipFileMember=HASH(0x9678fc)') called at ../lib/Archive/ Extract.pm line 753 # Archive::Extract::_unzip_az('Archive::Extract=HASH(0x966eac)') called at ../lib/ Archive/Extract.pm line 674 # Archive::Extract::_unzip('Archive::Extract=HASH(0x966eac)') called at ../lib/Archive/ Extract.pm line 275 # Archive::Extract::extract('Archive::Extract=HASH(0x966eac)','to','/Users/kane/sources/ p4/other/archive-extract/t/out') called at t/01_Archive-Extract.t line 180 The best way to check if that's the case for you, is to add this code to the beginning of the .t file: BEGIN { $SIG{__WARN__} = sub { require Carp; Carp::cluck(@_) } }; Sorry for not being able to do this in one go :( -- Jos

Wed Aug 09 17:55:04 2006 alexchorny [...] gmail.com - Correspondence added

Subject:	warnings under Cygwin
From:	Alexandr Ciornii <alexchorny [...] gmail.com>

One of the warnings, "Use of uninitialized value in string eq at /usr/lib/perl5/5.8/cygwin/File/Spec/Cygwin.pm line 50.", is the same warning as in #19713 for Archive::Zip. Submitted patch there. Another warning "Use of uninitialized value in split at /usr/lib/perl5/site_perl/5.8/Module/Load/Conditional.pm line 158." appears in 01_Archive-Extract.t at line $mod_fail++ unless check_install( module => $mod ); because there are lines: modules => [undef], and this results in call: check_install( module => undef ) Solving this two problems, will remove most, if not all, warnings. ------- Alexandr Ciornii, http://chorny.net

Sat Aug 12 15:56:05 2006 kane [...] cpan.org - Correspondence added

On Wed Aug 09 17:55:04 2006, alexchorny@gmail.com wrote: Show quoted text

> One of the warnings, "Use of uninitialized value in string eq at > /usr/lib/perl5/5.8/cygwin/File/Spec/Cygwin.pm line 50.", is the same > warning as in #19713 for Archive::Zip. Submitted patch there.

Cheers, well done! Show quoted text

> Another warning "Use of uninitialized value in split at > /usr/lib/perl5/site_perl/5.8/Module/Load/Conditional.pm line 158." > appears in 01_Archive-Extract.t at line > $mod_fail++ unless check_install( module => $mod ); > because there are lines: > modules => [undef], > and this results in call: > check_install( module => undef ) > > Solving this two problems, will remove most, if not all, warnings.

I've applied a fix for this in the development tree. Thanks for tracking this down! -- Jos

Sat Aug 12 15:56:06 2006 kane [...] cpan.org - Status changed from 'open' to 'resolved'