Bug #19802 for Class-DBI-AsForm: test failed , cpan wont install without force

Fri Jun 09 03:00:14 2006 Guest - Ticket created

Subject:

test failed , cpan wont install without force

tried to install using cpan, but it wont install without force: Removing previously used /root/.cpan/build/Class-DBI-AsForm-2.42 CPAN.pm: Going to build T/TM/TMTM/Class-DBI-AsForm-2.42.tar.gz Checking if your kit is complete... Looks good Writing Makefile for Class::DBI::AsForm cp lib/Class/DBI/AsForm.pm blib/lib/Class/DBI/AsForm.pm Manifying blib/man3/Class::DBI::AsForm.3pm /usr/bin/make -j3 -- OK Running make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01..............ok 1/4 t/01..............NOK 3# Failed test 'Select OK' # in t/01.t at line 43. # got: '<select name="bar"><option value="1">Hi</option></select> # ' # expected: '<select name="bar"><option value=1>Hi</option></select> # ' # Failed test 'All correct as an object method' # in t/01.t at line 54. t/01..............NOK 4# Structures begin differing at: # $got->{bar} = '<select name="bar"><option selected value="1">Hi</option></select> # ' # $expected->{bar} = '<select name="bar"><option selected value=1>Hi</option></select> # ' # Looks like you failed 2 tests of 4. t/01..............dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 3-4 Failed 2/4 tests, 50.00% okay t/pod-coverage....skipped all skipped: Test::Pod::Coverage 1.00 required for testing POD coverage t/pod.............skipped all skipped: Test::Pod 1.00 required for testing POD Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/01.t 2 512 4 2 50.00% 3-4 2 tests skipped. Failed 1/3 test scripts, 66.67% okay. 2/4 subtests failed, 50.00% okay. make: *** [test_dynamic] Error 255 /usr/bin/make test -- NOT OK Running make install make test had returned bad status, won't install without force ---------------- seems like value=1 in select box isn't quoted. alfarid

Mon Jul 24 21:54:43 2006 mrallen1 [...] yahoo.com - Correspondence added

From:

mrallen1 [...] yahoo.com

This happens with HTML::Element 3.20 because it is returning XHTML stuff now and the tests don't expect it. You can just patch the test scripts using this patch if you want a clean make && make test && make install process. On Fri Jun 09 03:00:14 2006, guest wrote: Show quoted text

> tried to install using cpan, but it wont install without force: > > Removing previously used /root/.cpan/build/Class-DBI-AsForm-2.42 > > CPAN.pm: Going to build T/TM/TMTM/Class-DBI-AsForm-2.42.tar.gz > > Checking if your kit is complete... > Looks good > Writing Makefile for Class::DBI::AsForm > cp lib/Class/DBI/AsForm.pm blib/lib/Class/DBI/AsForm.pm > Manifying blib/man3/Class::DBI::AsForm.3pm > /usr/bin/make -j3 -- OK > Running make test > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/01..............ok 1/4 > t/01..............NOK 3# Failed test 'Select OK' > # in t/01.t at line 43. > # got: '<select name="bar"><option > value="1">Hi</option></select> > # ' > # expected: '<select name="bar"><option > value=1>Hi</option></select> > # ' > > # Failed test 'All correct as an object method' > # in t/01.t at line 54. > t/01..............NOK 4# Structures begin differing at: > # $got->{bar} = '<select name="bar"><option selected > value="1">Hi</option></select> > # ' > # $expected->{bar} = '<select name="bar"><option selected > value=1>Hi</option></select> > # ' > # Looks like you failed 2 tests of 4. > t/01..............dubious > Test returned status 2 (wstat 512, 0x200) > DIED. FAILED tests 3-4 > Failed 2/4 tests, 50.00% okay > t/pod-coverage....skipped > all skipped: Test::Pod::Coverage 1.00 required for testing POD > coverage > t/pod.............skipped > all skipped: Test::Pod 1.00 required for testing POD > Failed Test Stat Wstat Total Fail Failed List of Failed >

------------------------------------------------------------------------------- Show quoted text

> t/01.t 2 512 4 2 50.00% 3-4 > 2 tests skipped. > Failed 1/3 test scripts, 66.67% okay. 2/4 subtests failed, 50.00% > okay. > make: *** [test_dynamic] Error 255 > /usr/bin/make test -- NOT OK > Running make install > make test had returned bad status, won't install without force > > > > ---------------- > > seems like value=1 in select box isn't quoted. > > alfarid

--- 01.t.orig 2006-07-24 20:37:40.000000000 -0500 +++ 01.t 2006-07-24 20:38:10.000000000 -0500 @@ -40,15 +40,15 @@ "Ordinary text field OK"); Foo->has_a(bar => Bar); -is(Foo->to_field("bar"), "<select name=\"bar\"><option value=1>Hi</option></select>\n", +is(Foo->to_field("bar"), "<select name=\"bar\"><option value=\"1\">Hi</option></select>\n", "Select OK"); my $x = bless({id => 1, bar => Bar->retrieve_all(), baz => "Hello there"}, "Foo"); -my %cgi = ( id => '<input name="id" type="text" value=1> +my %cgi = ( id => '<input name="id" type="text" value="1" /> ', - bar => '<select name="bar"><option selected value=1>Hi</option></select> + bar => '<select name="bar"><option selected value="1">Hi</option></select> ', - baz => '<input name="baz" type="text" value="Hello there"> + baz => '<input name="baz" type="text" value="Hello there" /> ' ); is_deeply({$x->to_cgi}, \%cgi, "All correct as an object method");

Mon Jul 24 21:54:45 2006 The RT System itself - Status changed from 'new' to 'open'

Sun Oct 19 12:10:24 2008 SREZIC [...] cpan.org - Correspondence added

On Mon Jul 24 21:54:43 2006, mallen wrote: Show quoted text

> This happens with HTML::Element 3.20 because it is returning XHTML > stuff > now and the tests don't expect it. You can just patch the test scripts > using this patch if you want a clean make && make test && make install > process. >

Alternatively the test could use "like" instead of "is" and accepts both forms, the XHTML and the old HTML output. Regards, Slaven