Bug #19725 for Audio-MPEG: Will not make

在 2006-06-08 14:31:23 星期四 时，west.finchley@leegoddard.net 写到： Show quoted text
I encountered the same problem, and some warning become error in my environment. System: Ubuntu 7.10 Gcc: 4.1.3 perl: 5.8.8 Lame: 3.97 Mad: 0.15.1b After investigation, I found it mainly caused by macro Newz and variable flags(type is lame_t). Using Newz(0, (void *)RETVAL, sizeof(*RETVAL), char) caused the follow problem: MPEG.xs: In function 'XS_Audio__MPEG__Decode_new': MPEG.xs:59: error: invalid lvalue in assignment After macro expansion, the parameter (void *)RETVAL used as a lvalue. Type-cast for a lvalue is a warning in some early version of gcc, but an error in my current version. So I have to change (void *)RETVAL into RETVAL when using Newz. Lots of errors caused by flags which defined as lame_t *flags in file encode.h. Look into lame.h, we can found: struct lame_global_struct; typedef struct lame_global_struct lame_global_flags; typedef lame_global_flags *lame_t; So flags is a pointer of pointer which point to a struct lame_global_struct, obvious, it is not the author's intention.(I think the lame.h has changed). Anyway, we have to change all lame_t * into lame_t. And then make will be successful, you can use it normally, although it still can not through the 'make test'. Btw: I found there isn't lame_global_flags.h in the liblame-dev, which defines the struct lame_global_struct, so I found one from internet.

/* * $Id: encode.h,v 1.1.1.1 2001/06/17 01:37:51 ptimof Exp $ * * Copyright (c) 2001 Peter Timofejew. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #ifndef AUDIO_MPEG_ENCODE_H #define AUDIO_MPEG_ENCODE_H #include <lame/lame.h> #include <lame/lame_global_flags.h> #include "audio.h" struct audio_mpeg_encode { lame_t flags; unsigned int encode_delay_applied; }; typedef struct audio_mpeg_encode * Audio_MPEG_Encode; int encode_new(Audio_MPEG_Encode); void encode_DESTROY(Audio_MPEG_Encode); unsigned int lame_encode_buffer_interleaved_float(lame_t , float *, unsigned int, unsigned char *, unsigned int); #endif

#ifndef LAME_GLOBAL_FLAGS_H #define LAME_GLOBAL_FLAGS_H #ifndef lame_internal_flags_defined #define lame_internal_flags_defined struct lame_internal_flags; typedef struct lame_internal_flags lame_internal_flags; #endif typedef enum short_block_e { short_block_not_set = -1, /* allow LAME to decide */ short_block_allowed = 0, /* LAME may use them, even different block types for L/R */ short_block_coupled, /* LAME may use them, but always same block types in L/R */ short_block_dispensed, /* LAME will not use short blocks, long blocks only */ short_block_forced /* LAME will not use long blocks, short blocks only */ } short_block_t; /*********************************************************************** * * Control Parameters set by User. These parameters are here for * backwards compatibility with the old, non-shared lib API. * Please use the lame_set_variablename() functions below * * ***********************************************************************/ struct lame_global_struct { /* input description */ unsigned long num_samples; /* number of samples. default=2^32-1 */ int num_channels; /* input number of channels. default=2 */ int in_samplerate; /* input_samp_rate in Hz. default=44.1 kHz */ int out_samplerate; /* output_samp_rate. default: LAME picks best value at least not used for MP3 decoding: Remember 44.1 kHz MP3s and AC97 */ float scale; /* scale input by this amount before encoding at least not used for MP3 decoding */ float scale_left; /* scale input of channel 0 (left) by this amount before encoding */ float scale_right; /* scale input of channel 1 (right) by this amount before encoding */ /* general control params */ int analysis; /* collect data for a MP3 frame analyzer? */ int bWriteVbrTag; /* add Xing VBR tag? */ int decode_only; /* use lame/mpglib to convert mp3 to wav */ int quality; /* quality setting 0=best, 9=worst default=5 */ MPEG_mode mode; /* see enum in lame.h default = LAME picks best value */ int force_ms; /* force M/S mode. requires mode=1 */ int free_format; /* use free format? default=0 */ int findReplayGain; /* find the RG value? default=0 */ int decode_on_the_fly; /* decode on the fly? default=0 */ /* * set either brate>0 or compression_ratio>0, LAME will compute * the value of the variable not set. * Default is compression_ratio = 11.025 */ int brate; /* bitrate */ float compression_ratio; /* sizeof(wav file)/sizeof(mp3 file) */ /* frame params */ int copyright; /* mark as copyright. default=0 */ int original; /* mark as original. default=1 */ int extension; /* the MP3 'private extension' bit. Meaningless */ int emphasis; /* Input PCM is emphased PCM (for instance from one of the rarely emphased CDs), it is STRONGLY not recommended to use this, because psycho does not take it into account, and last but not least many decoders don't care about these bits */ int error_protection; /* use 2 bytes per frame for a CRC checksum. default=0 */ int strict_ISO; /* enforce ISO spec as much as possible */ int disable_reservoir; /* use bit reservoir? */ /* quantization/noise shaping */ int quant_comp; int quant_comp_short; int experimentalY; int exp_nspsytune; int preset; /* VBR control */ vbr_mode VBR; int VBR_q; int VBR_mean_bitrate_kbps; int VBR_min_bitrate_kbps; int VBR_max_bitrate_kbps; int VBR_hard_min; /* strictly enforce VBR_min_bitrate normaly, it will be violated for analog silence */ /* resampling and filtering */ int lowpassfreq; /* freq in Hz. 0=lame choses. -1=no filter */ int highpassfreq; /* freq in Hz. 0=lame choses. -1=no filter */ int lowpasswidth; /* freq width of filter, in Hz (default=15%) */ int highpasswidth; /* freq width of filter, in Hz (default=15%) */ /* * psycho acoustics and other arguments which you should not change * unless you know what you are doing */ int psymodel; /* select psychoacoustic model */ float maskingadjust; float maskingadjust_short; int ATHonly; /* only use ATH */ int ATHshort; /* only use ATH for short blocks */ int noATH; /* disable ATH */ int ATHtype; /* select ATH formula */ float ATHcurve; /* change ATH formula 4 shape */ float ATHlower; /* lower ATH by this many db */ int athaa_type; /* select ATH auto-adjust scheme */ int athaa_loudapprox; /* select ATH auto-adjust loudness calc */ float athaa_sensitivity; /* dB, tune active region of auto-level */ int cwlimit; /* predictability limit */ short_block_t short_blocks; int useTemporal; /* use temporal masking effect */ float interChRatio; float msfix; /* Naoki's adjustment of Mid/Side maskings */ int tune; /* 0 off, 1 on */ float tune_value_a; /* used to pass values for debugging and stuff */ int quantization_type; /* 0 depending on quality, 1 ISO, 2 nonlinear */ struct { void (*msgf) (const char *format, va_list ap); void (*debugf) (const char *format, va_list ap); void (*errorf) (const char *format, va_list ap); } report; /************************************************************************/ /* internal variables, do not set... */ /* provided because they may be of use to calling application */ /************************************************************************/ int version; /* 0=MPEG-2/2.5 1=MPEG-1 */ int encoder_delay; int encoder_padding; /* number of samples of padding appended to input */ int framesize; int frameNum; /* number of frames encoded */ int lame_allocated_gfp; /* is this struct owned by calling program or lame? */ /**************************************************************************/ /* more internal variables are stored in this structure: */ /**************************************************************************/ lame_internal_flags *internal_flags; struct { int mmx; int amd3dnow; int sse; } asm_optimizations; }; #endif /* LAME_GLOBAL_FLAGS_H */