Skip Menu |

This queue is for tickets about the Test-Harness CPAN distribution.

Report information
The Basics
Id: 19505
Status: resolved
Priority: 0/
Queue: Test-Harness
People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in:
  • 2.58
  • 2.60
Fixed in: (no value)

History Show all quoted text
  Fri May 26 09:19:06 2006 jdhedden [...] cpan.org - Ticket created
Subject: 'make test' returns 'true' if tests fail
With Test::Harness 2.56, if a test fails, then 'make test' returns false back to the shell. I rely on this feature to keep bad modules from being installed, and for reporting test results. With 2.58 and 2.60, if a test fails, 'make test' now returns true.
  Fri May 26 09:41:18 2006 jdhedden [...] cpan.org - Status changed from 'new' to 'open'
  Fri May 26 10:31:08 2006 jdhedden [...] cpan.org - Correspondence added
On Fri May 26 09:19:06 2006, JDHEDDEN wrote: Show quoted text
> With Test::Harness 2.56, if a test fails, then 'make test' returns false > back to the shell. I rely on this feature to keep bad modules from > being installed, and for reporting test results. > > With 2.58 and 2.60, if a test fails, 'make test' now returns true.
This appears to be related to bug #17490: http://rt.cpan.org/Ticket/Display.html?id=17490
  Fri May 26 10:31:10 2006 jdhedden [...] cpan.org - Status changed from 'open' to 'new'
  Fri May 26 11:51:36 2006 jdhedden [...] cpan.org - Correspondence added
On Fri May 26 09:19:06 2006, JDHEDDEN wrote: Show quoted text
> With Test::Harness 2.56, if a test fails, then 'make test' returns false > back to the shell. I rely on this feature to keep bad modules from > being installed, and for reporting test results. > > With 2.58 and 2.60, if a test fails, 'make test' now returns true.
The attached patch restores the documented behavior.
--- lib/Test/Harness.pm.orig 2006-05-26 11:19:52.000000000 -0400 +++ lib/Test/Harness.pm 2006-05-26 11:47:50.000000000 -0400 @@ -214,6 +214,11 @@ assert(($ok xor keys %$failedtests), q{ok status jives with $failedtests}); + if (! $ok) { + die("Failed $tot->{bad}/$tot->{tests} test scripts. " . + "@{[$tot->{max} - $tot->{ok}]}/$tot->{max} subtests failed.\n"); + } + return $ok; }
  Fri May 26 11:51:38 2006 jdhedden [...] cpan.org - Status changed from 'new' to 'open'
  Thu Jun 08 10:42:13 2006 MTHURN [...] cpan.org - Correspondence added
Thank you for the patch. I just want to reiterate the importance of this bug. CPANPLUS relies on the die in order to determine when NOT to install a broken module. Without this patch, CPANPLUS is installing ALL modules even if they fail tests. -- - - Martin 'Kingpin' Thurn
  Thu Jun 08 15:07:11 2006 PETDANCE [...] cpan.org - Correspondence added
Fixed in 2.62. I'm sorry this got past me for so long. :-(
  Thu Jun 08 15:07:12 2006 PETDANCE [...] cpan.org - Status changed from 'open' to 'resolved'