Skip Menu |

This queue is for tickets about the PAR CPAN distribution.

Report information
The Basics
Id: 19483
Status: resolved
Priority: 0/
Queue: PAR

People
Owner: smueller [...] cpan.org
Requestors: razinf [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.93
Fixed in: (no value)



Subject: PAR-0.93 make test failed in FC5
While older version like PAR-0.88 is Ok on PAR-0.93 == make test fails and out.make file complains that make was not found. The error occurs when Inline::C is called for the last test in 30-current_exec.t. A problem was encountered while attempting to compile and install your Inline C code. The command that failed was: make > out.make 2>&1 The build directory was: /root/.cpan/build/PAR-0.93/_Inline/build/_30_current_exec_t_c76e To debug the problem, cd to the build directory, and inspect the output files. at t/30-current_exec.t line 66 perl -v: perl, v5.8.8 built for i386-linux-thread-multi uname -a:Linux callisto 2.6.16-1.2122_FC5 #1 Sun May 21 15:01:01 EDT 2006 i686 i686 i386 GNU/Linux
On Do. 25. Mai 2006, 16:02:25, guest wrote: Show quoted text
> While older version like PAR-0.88 is Ok on PAR-0.93 > == > make test fails and out.make file complains that make was not found. > The error occurs when Inline::C is called for the last test in > 30-current_exec.t. > > > > A problem was encountered while attempting to compile and install your > Inline > C code. The command that failed was: > make > out.make 2>&1 > > The build directory was: > /root/.cpan/build/PAR-0.93/_Inline/build/_30_current_exec_t_c76e > > To debug the problem, cd to the build directory, and inspect the output > files. > > at t/30-current_exec.t line 66
This is most likely a bug in the test script. I will investigate further as soon as I can. Until then, please just install PAR regardless of this failed test. Sorry, Steffen
On Thu May 25 16:22:48 2006, SMUELLER wrote: Show quoted text
> On Do. 25. Mai 2006, 16:02:25, guest wrote:
> > at t/30-current_exec.t line 66
> > This is most likely a bug in the test script. I will investigate further > as soon as I can. Until then, please just install PAR regardless of this > failed test.
It appears that this test smashes the path. I get (with TEST_VERBOSE=1) the error: sh: line 1: make: command not found The attached path seems to fix it. --Eric
Index: t/30-current_exec.t =================================================================== --- t/30-current_exec.t (revision 3) +++ t/30-current_exec.t (working copy) @@ -47,7 +47,7 @@ my( $file, $path ) = fileparse( $EXEC ); -$ENV{PATH} = $path; +$ENV{PATH} .= ':' . $path; my $out_path = qx($file); is( $out_path, $out_full, "Found the same file via PATH and full path" );
CC: SMUELLER [...] cpan.org
Subject: Re: [rt.cpan.org #19483] PAR-0.93 make test failed in FC5
Date: Sat, 27 May 2006 10:04:02 -0300 (IDT)
To: bug-PAR [...] rt.cpan.org
From: "Oded S. Resnik" <razinf [...] cpan.org>
The patch Eric published fixes the problem on my system
From: smueller [...] cpan.org
On Sa. 27. Mai 2006, 00:36:58, EWILHELM wrote: Show quoted text
> On Thu May 25 16:22:48 2006, SMUELLER wrote:
> > On Do. 25. Mai 2006, 16:02:25, guest wrote:
> > > at t/30-current_exec.t line 66
> > > > This is most likely a bug in the test script. I will investigate further > > as soon as I can. Until then, please just install PAR regardless of this > > failed test.
> > It appears that this test smashes the path. I get (with TEST_VERBOSE=1) > the error: > > sh: line 1: make: command not found > > The attached path seems to fix it. > > --Eric
The test fiel has already been modified before the patch in this ticket arrived. Would you consider running the attached version of the test script to see if that works? Steffen
#!/usr/bin/perl -w # $Id$ use strict; use Config; use File::Spec; use File::Path; use File::Basename; use FindBin; use Test::More ( tests => 4 ); my $has_inline_c = eval "use Inline; 1;"; # warn $@ if $@; #### my $EXEC = File::Spec->catfile( $FindBin::Bin, "test-10.exec" ); my $TEMP = join '-', $FindBin::Bin, "tmp"; my $SCRIPT = File::Spec->catdir( $FindBin::Bin, File::Spec->updir, "blib", "script" ); my $PP = File::Spec->catfile( $SCRIPT, 'pp' ); my $p = File::Spec->catdir("blib", "lib"); my $sep = $Config{path_sep}; $sep = ':' if not defined $sep; $p .= $sep if $ENV{PERL5LIB}; $ENV{PERL5LIB} = defined($ENV{PERL5LIB}) ? $p . $ENV{PERL5LIB} : $p; #### unlink $EXEC if -f $EXEC; rmtree( [$TEMP] ) if -d $TEMP; mkpath( [$TEMP], 0, 0700 ); #### diag( "Please wait" ); my $test_proc = File::Spec->catfile('t', 'test-proc'); system( "$PP -o $EXEC $test_proc" ); ok( (-f $EXEC), "Created $EXEC" ) or die "Failed to create $EXEC!\n"; #### $ENV{PAR_GLOBAL_TMPDIR} = $TEMP; my $out_full = qx($EXEC); ok( ($out_full =~ /PAR_TEMP = $TEMP/), "Respected PAR_GLOBAL_TMPDIR" ); my( $file, $path ) = fileparse( $EXEC ); my $out_path = do { local $ENV{PATH} = $path; qx($file); }; is( $out_path, $out_full, "Found the same file via PATH and full path" ); # warn qq(out_full="$out_full"\n out_path="$out_path"\n);; #### SKIP: { skip "Inline::C not installed; Can't verify with execvp", 1 unless $has_inline_c; skip "Can't get running executable that isn't in PATH on $^O", 1 unless $^O =~ /linux/i or ( $^O =~ /freebsd/i and -l "/proc/$$/file" ); diag( "Please wait" ); Inline->bind( C => <<'C' ); #include <unistd.h> #include <stdio.h> void exec_prog( char *full_path, char *exec ) { char * args[]={NULL, NULL}; args[0] = exec; execvp( full_path, args ); perror( "execvp failed" ); exit(3); } C my $pid = open PROG, "-|"; die "Can't fork: $!" unless defined $pid; unless( $pid ) { # child $ENV{PAR_GLOBAL_TMPDIR} = $TEMP; # warn "EXEC=$EXEC file=$file" ; $ENV{PATH} = $path; exec_prog( $EXEC, $file ); } my $exec_full = join '', <PROG>; is( $exec_full, $out_path, "Found the same file via execvp and PATH" ); } #### Clean up unlink $EXEC; rmtree( [$TEMP] ); mkpath( [$TEMP], 0, 0700 ); 1; __END__ $Log$
On שני מאי 29 04:45:54 2006, SMUELLER wrote: Show quoted text
> On Sa. 27. Mai 2006, 00:36:58, EWILHELM wrote:
> > On Thu May 25 16:22:48 2006, SMUELLER wrote:
> > > On Do. 25. Mai 2006, 16:02:25, guest wrote:
> > > > at t/30-current_exec.t line 66
> > > > > > This is most likely a bug in the test script. I will investigate
further Show quoted text
> > > as soon as I can. Until then, please just install PAR regardless
of this Show quoted text
> > > failed test.
> > > > It appears that this test smashes the path. I get (with TEST_VERBOSE=1) > > the error: > > > > sh: line 1: make: command not found > > > > The attached path seems to fix it. > > > > --Eric
> > The test fiel has already been modified before the patch in this ticket > arrived. Would you consider running the attached version of the test > script to see if that works? > > Steffen
Hi Steffen, Checked the file you attached with PAR-0.93 and it's ok ! PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/1-basic.t t/2-pp.t t/30-current_exec.t t/1-basic............ok t/2-pp...............ok t/30-current_exec....# Please wait t/30-current_exec....ok 2/4# Please wait t/30-current_exec....ok All tests successful.