Bug #19438 for CPANPLUS: Key 'file' is of invalid type

Tue May 23 10:23:30 2006 MTHURN [...] cpan.org - Ticket created

Subject:

Key 'file' is of invalid type

[MSG] Extracted 'Math::Geometry::Planar::Offset' to '/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry-Planar-Offset-1.04' Running [/usr/local/bin/perl5.9.2 -MCPANPLUS::Internals::Utils::Autoflush Makefile.PL ]... # running Build.PL /usr/local/bin/perl5.9.2 Build.PL Checking whether your kit is complete... Looks good Checking prerequisites... Looks good Creating new 'Build' script for 'Math-Geometry-Planar-Offset' version '1.04' [ERROR] File '/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry-Planar-Offset-1.04/Makefile' is not readable or does not exist Key 'file' (/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry-Planar-Offset-1.04/Makefile) is of invalid type for 'CPANPLUS::Dist::MM::_find_prereqs' provided by CPANPLUS::Dist::MM::prepare at /usr/local/lib/perl5/site_perl/5.9.2/CPANPLUS/Module.pm line 602 [ERROR] Unable to scan '/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry-Planar-Offset-1.04/Makefile' for prereqs [ERROR] Unable to create a new distribution object for 'Math::Geometry::Planar::Offset' -- cannot continue Error installing 'Math::Geometry::Planar::Offset' Problem installing one or more modules -- - - Martin 'Kingpin' Thurn

Tue May 23 11:19:05 2006 kane [...] xs4all.net - Correspondence added

Subject:	Re: [rt.cpan.org #19438] Key 'file' is of invalid type
Date:	Tue, 23 May 2006 17:18:52 +0200
To:	bug-CPANPLUS [...] rt.cpan.org
From:	"Jos I. Boumans" <kane [...] xs4all.net>

On May 23, 2006, at 4:23 PM, Martin Thurn via RT wrote: Show quoted text

> [ERROR] File '/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry- > Planar-Offset-1.04/Makefile' is not readable or does not exist > > Key 'file' (/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry- > Planar-Offset-1.04/Makefile) is of invalid type for > 'CPANPLUS::Dist::MM::_find_prereqs' provided by > CPANPLUS::Dist::MM::prepare at /usr/local/lib/perl5/site_perl/5.9.2/ > CPANPLUS/Module.pm line 602

Not sure what the 'bug' report is here -- the diagnostics on the 2nd line are a direct result of the [ERROR] mentioned on the line before. Perhaps that wasn't clear and this was a request to improve that diagnostic?

Tue May 23 11:19:06 2006 The RT System itself - Status changed from 'new' to 'open'

Wed May 24 07:08:46 2006 mthurn [...] verizon.net - Correspondence added

Subject:	RE: [rt.cpan.org #19438] Key 'file' is of invalid type
Date:	Wed, 24 May 2006 07:09:55 -0400
To:	<bug-CPANPLUS [...] rt.cpan.org>, <MTHURN [...] cpan.org>
From:	"Martin Thurn" <mthurn [...] verizon.net>

Show quoted text

> On May 23, 2006, at 4:23 PM, Martin Thurn via RT wrote:

> > [ERROR] File '/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry- > > Planar-Offset-1.04/Makefile' is not readable or does not exist > > > > Key 'file' (/disk1/src/PERL/.cpanplus/5.9.2/build/Math-Geometry- > > Planar-Offset-1.04/Makefile) is of invalid type for > > 'CPANPLUS::Dist::MM::_find_prereqs' provided by > > CPANPLUS::Dist::MM::prepare at

> /usr/local/lib/perl5/site_perl/5.9.2/

> > CPANPLUS/Module.pm line 602

> > > Not sure what the 'bug' report is here -- the diagnostics on the 2nd > line are a direct result of the [ERROR] mentioned on the line before.

Oh I see. Apparently the second line was so "scary" I didn't even see the first line! IMO if you detect and report an [ERROR] you should prevent a "low-level" spew of Perl code warning...

Wed May 24 07:13:45 2006 kane [...] xs4all.net - Correspondence added

Subject:	Re: [rt.cpan.org #19438] Key 'file' is of invalid type
Date:	Wed, 24 May 2006 13:13:38 +0200
To:	bug-CPANPLUS [...] rt.cpan.org
From:	"Jos I. Boumans" <kane [...] xs4all.net>

On May 24, 2006, at 1:08 PM, mthurn@verizon.net via RT wrote: Show quoted text

>> Not sure what the 'bug' report is here -- the diagnostics on the 2nd >> line are a direct result of the [ERROR] mentioned on the line before.

> > Oh I see. Apparently the second line was so "scary" I didn't even > see the > first line! IMO if you detect and report an [ERROR] you should > prevent a > "low-level" spew of Perl code warning...

Seems reasonable -- if someone as comfortable with perl guts as you gets frightned by it, it probably warrnats fixing... i'll look into it. Thanks for reporting, -- Jos

Tue Jun 06 10:35:31 2006 kane [...] cpan.org - Correspondence added

On Wed May 24 07:13:45 2006, kane@xs4all.net wrote: Show quoted text

> > On May 24, 2006, at 1:08 PM, mthurn@verizon.net via RT wrote:

> >> Not sure what the 'bug' report is here -- the diagnostics on the 2nd > >> line are a direct result of the [ERROR] mentioned on the line before.

You've actually stumbled upon a deeper error. It seems that module build has an interesting feature that throws us off here. I've added the following patch to catch this situation, and reported the bug to the module::build folks as bug #19741. I'm afraid that's all i can do for now :( ==== //depot/cpanplus/devel/lib/CPANPLUS/Dist/MM.pm#63 - /Users/kane/sources/p4/ cpanplus/devel/lib/CPANPLUS/Dist/MM.pm ==== 300a301,320 Show quoted text

> ### so, nasty feature in Module::Build, that when a Makefile.PL > ### is a disguised Build.PL, it generates a Build file, not a > ### Makefile. this breaks everything :( see rt bug #19741 > if( not -e MAKEFILE->( $dir ) and -e BUILD_PL->( $dir ) ) { > error(loc( > "We just ran '%1' without errors, but no '%2' is ". > "present. However, there is a '%3' file, so this may ". > "be related to bug #19741 in %4, which describes a ". > "fake '%5' which generates a '%6' file instead of a '%7'. ". > "You could try to work around this issue by setting '%8' ". > "to false and trying again. This will attempt to use the ". > "'%9' instead.", > "$^X ".MAKEFILE_PL->(), MAKEFILE->(), BUILD_PL->(), > 'Module::Build', MAKEFILE_PL->(), 'Build', MAKEFILE->(), > 'prefer_makefile', BUILD_PL->() > )); > > $fail++, last RUN; > } >

Tue Jun 06 10:35:32 2006 kane [...] cpan.org - Status changed from 'open' to 'resolved'