Skip Menu |

This queue is for tickets about the Algorithm-RabinKarp CPAN distribution.

Report information
The Basics
Id: 19388
Status: resolved
Priority: 0/
Queue: Algorithm-RabinKarp
People
Owner: NNUNLEY [...] cpan.org
Requestors: martin.busik [...] busik.de
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.34
Fixed in: (no value)

History Show all quoted text
  Sun May 21 11:20:36 2006 Guest - Ticket created
Subject: Constructor problems
example t\hash.t is not working - at least under perl 5.6.1. This example uses the ($window,SCALAR) variant of the constructor. the constructor interpretes this as a filename - which is wrong. Further, a check is made if the given parameter is a subclass of IO::Filehandle by calling: $source->isa("IO::Handle") This fails, if $source is just a coderef, not a blessed reference. The check is better written as UNIVERSAL->isa("IO::Handle") Regards, Martin
  Mon May 22 06:50:30 2006 nnunley [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #19388] Constructor problems
Date: Mon, 22 May 2006 11:49:17 +0100
To: bug-Algorithm-RabinKarp [...] rt.cpan.org
From: "Norman Nunley, Jr" <nnunley [...] gmail.com>
Thanks, Martin. I'll commit a fix today. Norman On 21 May 2006, at 16:20, Guest via RT wrote: Show quoted text
> > Sun May 21 11:20:36 2006: Request 19388 was acted upon. > Transaction: Ticket created by guest > Queue: Algorithm-RabinKarp > Subject: Constructor problems > Broken in: 0.34 > Severity: Important > Owner: Nobody > Requestors: martin.busik@busik.de > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=19388 > > > > example t\hash.t is not working - at least under perl 5.6.1. > > This example uses the ($window,SCALAR) variant of the constructor. > the constructor interpretes this as a filename - which is wrong. > > Further, a check is made if the given parameter is a subclass of > IO::Filehandle by calling: $source->isa("IO::Handle") > > This fails, if $source is just a coderef, not a blessed reference. > The check is better written as UNIVERSAL->isa("IO::Handle") > > Regards, > Martin > >
  Mon May 22 06:50:31 2006 The RT System itself - Status changed from 'new' to 'open'
  Mon May 22 08:12:47 2006 NNUNLEY [...] cpan.org - Taken
  Tue May 23 10:23:54 2006 Guest - Correspondence added
From: nnunley [...] gmail.com
Hi, Martin I've switched to UNIVERSAL for type checking, and rewritten the scalar handling. I think I might be able to reduce the minimum perl version number now. Could you confirm that it works for you? The old version was explicitly marked as being for perl 5.8 and greater because of some of the language features I was using (including opening scalar values as 'files', without directly resorting to using the IO::Scalar package) The new scalar handler is actually a good deal simpler, as it just does substr extraction. Let me know if it works for you. Norman On Sun May 21 11:20:36 2006, guest wrote: Show quoted text
> example t\hash.t is not working - at least under perl 5.6.1. > > This example uses the ($window,SCALAR) variant of the constructor. > the constructor interpretes this as a filename - which is wrong. > > Further, a check is made if the given parameter is a subclass of > IO::Filehandle by calling: $source->isa("IO::Handle") > > This fails, if $source is just a coderef, not a blessed reference. > The check is better written as UNIVERSAL->isa("IO::Handle") > > Regards, > Martin
  Wed May 24 04:03:10 2006 martin.busik [...] busik.de - Correspondence added
Subject: AW: [rt.cpan.org #19388] Constructor problems
Date: Wed, 24 May 2006 10:01:54 +0200
To: <bug-Algorithm-RabinKarp [...] rt.cpan.org>
From: martin.busik [...] busik.de
Hi Norman, Show quoted text
>I think I might be able to reduce the minimum perl version number now. Could >you confirm that it works for you?
0.35 works fine for me with both perl 5.6.1 as well as 5.8.8. There is an another issue, a little one: In order to perform make test Test:::Exception is required, I had to install it for both perl versions. AFAIK it is possible to distinguish between a runtime- and a build-prerequisite. I've no idea if it is possible to declare (in Makefile.PL) a test prerequisite. Regards, Martin
  Wed May 24 09:20:26 2006 nnunley [...] gmail.com - Correspondence added
Subject: Re: AW: [rt.cpan.org #19388] Constructor problems
Date: Wed, 24 May 2006 14:19:30 +0100
To: bug-Algorithm-RabinKarp [...] rt.cpan.org
From: "Norman Nunley, Jr" <nnunley [...] gmail.com>
Sorry about the dependencies. I've repaired them for 0.36: Test::More is listed as a build requirement, and Test::Exception is just recommended. The construction tests will be skipped if you don't have Test::Exception installed. At some point, I might fix it such that Test::Exception is not required at all, but not quite yet. Thanks for testing A::R with 5.6.1. Out of curiosity, how are you going to use A::R? Regards, Norman On 24 May 2006, at 09:03, martin.busik@busik.de via RT wrote: Show quoted text
> > Queue: Algorithm-RabinKarp > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=19388 > > > Hi Norman, >
>> I think I might be able to reduce the minimum perl version number >> now. Could >> you confirm that it works for you?
> > 0.35 works fine for me with both perl 5.6.1 as well as 5.8.8. > > There is an another issue, a little one: In order to perform make test > Test:::Exception is required, I had to install it for both perl > versions. > > AFAIK it is possible to distinguish between a runtime- and a build- > prerequisite. I've no idea if it is possible to declare (in > Makefile.PL) a test prerequisite. > > Regards, > > Martin >
  Wed May 24 09:26:37 2006 NNUNLEY [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed May 24 10:59:39 2006 martin.busik [...] busik.de - Correspondence added
Subject: AW: Re: AW: [rt.cpan.org #19388] Constructor problems
Date: Wed, 24 May 2006 16:59:23 +0200
To: <bug-Algorithm-RabinKarp [...] rt.cpan.org>
From: martin.busik [...] busik.de
Hello Norman, Show quoted text
> Out of curiosity, how are you going to use A::R?
Good question ;-) I'm reading the CPAN-recent-RSS feed, this was my first touch to the RabinKarp algorithm. Thanks to the link in your documentation I've read the article on winnowing. Now I have at least an idea what it can do. Currently I do not have the "problem" for it, but - as so often in life - if you know a solution, you'll see a problem somewhere too. What about you? How are you using A::R? Regards, Martin
  Wed May 24 10:59:40 2006 The RT System itself - Status changed from 'resolved' to 'open'
  Tue Aug 01 11:43:39 2006 NNUNLEY [...] cpan.org - Status changed from 'open' to 'resolved'