Skip Menu |

This queue is for tickets about the YAML-Syck CPAN distribution.

Report information
The Basics
Id: 19313
Status: resolved
Priority: 0/
Queue: YAML-Syck
People
Owner: TODDR [...] cpan.org
Requestors: kevinj [...] activestate.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 0.60

History Show all quoted text
  Wed May 17 15:26:37 2006 kevinj [...] cpan.org - Ticket created
Subject: Incorrect parsing of newlines
perl -MJSON::Syck -le 'print JSON::Syck::Dump({a => "hello\nworld\n"})' This should produce: {"a":"hello\nworld\n"} but instead produces: {"a":"hello\n\ world\n"}
  Wed May 17 15:29:03 2006 kevinj [...] cpan.org - Correspondence added
Show quoted text
> {"a":"hello\n\ > > world\n"}
Ah, you can't see it very well in this font, but the newline is replaced by \n followed by a literal newline and two spaces
  Wed May 17 15:29:05 2006 The RT System itself - Status changed from 'new' to 'open'
  Fri May 26 16:33:09 2006 Guest - Correspondence added
Here's my patch which fixes this bug... It doesn't break any unit tests in this package, YAML::Syck, nor why's libsyck
==== //depot/main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/emitter.c#1 - /usr/home/kevinj/depot/main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/emitter.c ==== Index: main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/emitter.c --- main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/emitter.c.~1~ Fri May 26 13:32:08 2006 +++ main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/emitter.c Fri May 26 13:32:08 2006 @@ -871,7 +871,7 @@ case '\n': end = mark + 1; syck_emitter_write( e, "\\n", 2 ); - do_indent = 2; + //do_indent = 2; start = mark + 1; if ( start < str + len && ( *start == ' ' || *start == '\n' ) ) { do_indent = 0; ==== //depot/main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/t/01_json.t#1 - /usr/home/kevinj/depot/main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/t/01_json.t ==== Index: main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/t/01_json.t --- main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/t/01_json.t.~1~ Fri May 26 13:32:08 2006 +++ main/Appliance/apps/projects/goodfellow/cpan-packages/cpan-packages/JSON-Syck/t/01_json.t Fri May 26 13:32:08 2006 @@ -31,6 +31,7 @@ '["",null]', '{"foo":""}', '["\"://\""]', + '{"hw":"Hello\nWorld\n"}', ); plan tests => scalar @tests * (1 + $HAS_JSON) * 2; End of Patch.
  Wed Jan 25 13:46:10 2012 root [...] localhost - Queue changed from JSON-Syck to YAML-Syck
  Sat Feb 11 23:42:18 2012 TODDR [...] cpan.org - Taken
  Sat Feb 11 23:42:38 2012 TODDR [...] cpan.org - Fixed in 0.60 added
  Sat Feb 11 23:43:00 2012 TODDR [...] cpan.org - Correspondence added
Based on a bisect, this appears to have been resolved in 0.60
  Sat Feb 11 23:43:02 2012 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'