Skip Menu |

This queue is for tickets about the Archive-Rar CPAN distribution.

Report information
The Basics
Id: 1924
Status: resolved
Priority: 0/
Queue: Archive-Rar

People
Owner: Nobody in particular
Requestors: zed [...] 9hells.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: List method don't with default options
the problem is that the default value for -files option is '.' ... and this don't work for the List method, forcing the user to pass -file=>[] for this method to work, which does not seem the intented. the patch threat this exception, and fix a misplaced 'if' statment that would cause a warning (perl -w)
--- Rar-1.9.pm Fri Jan 3 09:53:08 2003 +++ Rar.pm Fri Jan 3 10:19:18 2003 @@ -203,11 +203,11 @@ sub SetOptions { while (($clef,$valeur) =each(%params)) { $args{$clef} =$valeur; } $me->{current} =\%args; - $args{'-files'} ='.' if (IsEmpty($args{'-files'})); + $args{'-files'} =$command eq 'vt' ? [] : '.' if (IsEmpty($args{'-files'})); $args{'-files'} =[ $args{'-files'} ] if (ref($args{'-files'}) eq ''); $me->{archive} =$args{'-archive'} if (!IsEmpty($args{'-archive'})); # print "ARCHIVE='$me->{archive}' '$args->{-archive}'\n"; if (defined $me->{archive} && $me->{archive} ne '') { @@ -297,12 +297,12 @@ Fin: # ---------------------------------------------------------------- # # sub _AddToList { my ($me,$pcurrfile,$pattrib) =@_; - return if ($pattrib->[6] =~ /d/i); return if ($#$pattrib < 0); + return if ($pattrib->[6] =~ /d/i); $me->{list} =() if (!defined $me->{list}); if ($pattrib->[3] =~ /(^<->$)|(^<--$)/) { $pcurrfile->{packed} +=$pattrib->[2]; $pcurrfile->{parts}++; } else {
To: bug-Archive-Rar [...] rt.cpan.org
Subject: Re: [cpan #1924] AutoReply: List method don't with default options
Date: Wed, 08 Jan 2003 00:34:41 -0200
From: zed [...] 9hells.org
RT-Send-Cc:
sorry, there is a typo in the bug-report title: - List method don't with default options + List method don't work with default options Show quoted text
> > Greetings, > This message has been automatically generated in response to your bug > report about Archive-Rar, a summary of which appears below. > > There is no need to reply to this message right now. Your bug in Archive-Rar > has been assigned an ID of [cpan #1924]. Please include the string: > > [cpan #1924] > > in the subject line of all future correspondence about this issue. To do so, > you may reply to this message. > > Thank you, > bug-Archive-Rar@rt.cpan.org > > ------------------------------------------------------------------------- > the problem is that the default value for -files option is '.' ... and this d > on't work for the List method, forcing the user to pass -file=>[] for this me > thod to work, which does not seem the intented. > > the patch threat this exception, and fix a misplaced 'if' statment that would > cause a warning (perl -w) >
Applied this patch for version 1.93.