Bug #18912 for CGI-Session: return value on param() call.

Tue Apr 25 07:53:57 2006 makoto [...] cpan.org - Ticket created

Subject:

Would you add for compatibility?

Session.pm 267a268,277 Show quoted text

> if( @_ == 2){ > my($name,$value) = @_; > if ( $name =~ m/^_SESSION_/ ) { > carp "param(): attempt to write to private parameter"; > return undef; > } > $self->_set_status(STATUS_MODIFIED); > return $self->{_DATA}->{ $name } = $value; > } >

Tue Apr 25 09:51:11 2006 mark [...] summersault.com - Correspondence added

Subject:	Re: [rt.cpan.org #18912] Would you add for compatibility?
Date:	Tue, 25 Apr 2006 09:50:32 -0400
To:	via RT <bug-CGI-Session [...] rt.cpan.org>
From:	Mark Stosberg <mark [...] summersault.com>

On Tue, Apr 25, 2006 at 07:54:00AM -0400, via RT wrote: Show quoted text

> > Tue Apr 25 07:53:57 2006: Request 18912 was acted upon. > Transaction: Ticket created by MAKOTO > Queue: CGI-Session > Subject: Would you add for compatibility? > Owner: Nobody > Requestors: MAKOTO@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > > > Session.pm > 267a268,277

> > if( @_ == 2){ > > my($name,$value) = @_; > > if ( $name =~ m/^_SESSION_/ ) { > > carp "param(): attempt to write to private parameter"; > > return undef; > > } > > $self->_set_status(STATUS_MODIFIED); > > return $self->{_DATA}->{ $name } = $value; > > }

Thanks for the contribution MAKOTO. Could you also submit a test a fails with the current version, so I can see what the problem is? Also, you mention "compatibility". Do you know when we broke this compatibility?

Tue Apr 25 09:51:12 2006 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 26 00:32:32 2006 makoto [...] fes-total.com - Correspondence added

CC:	MAKOTO [...] cpan.org
Subject:	Re: [rt.cpan.org #18912] Would you add for compatibility?
Date:	Wed, 26 Apr 2006 13:31:13 +0900
To:	bug-CGI-Session [...] rt.cpan.org
From:	shin honda <makoto [...] fes-total.com>

In the former version, the value set when the value was set by the param method was returned. Moreover, the param method of CGI.pm also operates such. However, in 4.xx or later, a set of a value returns 1. I want the param method of CGI::Session to carry out the same operation as the param method of CGI.pm. mark@summersault.com via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > > On Tue, Apr 25, 2006 at 07:54:00AM -0400, via RT wrote: >

>>Tue Apr 25 07:53:57 2006: Request 18912 was acted upon. >>Transaction: Ticket created by MAKOTO >> Queue: CGI-Session >> Subject: Would you add for compatibility? >> Owner: Nobody >> Requestors: MAKOTO@cpan.org >> Status: new >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > >> >> >>Session.pm >>267a268,277 >>

>>>if( @_ == 2){ >>> my($name,$value) = @_; >>> if ( $name =~ m/^_SESSION_/ ) { >>> carp "param(): attempt to write to private parameter"; >>> return undef; >>> } >>> $self->_set_status(STATUS_MODIFIED); >>> return $self->{_DATA}->{ $name } = $value; >>>}

> > > Thanks for the contribution MAKOTO. > > Could you also submit a test a fails with the current version, so I can > see what the problem is? > > Also, you mention "compatibility". Do you know when we broke this > compatibility? > > >

Wed Jun 07 17:02:50 2006 Guest - Correspondence added

From:

mleblanc [...] cpan.org

On Wed Apr 26 00:32:32 2006, makoto@fes-total.com wrote: Show quoted text

> In the former version, the value set when the value was set by the param > method was returned. > Moreover, the param method of CGI.pm also operates such. > However, in 4.xx or later, a set of a value returns 1. > I want the param method of CGI::Session to carry out the same operation > as the param method of CGI.pm. > > mark@summersault.com via RT wrote:

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > > > > On Tue, Apr 25, 2006 at 07:54:00AM -0400, via RT wrote: > >

> >>Tue Apr 25 07:53:57 2006: Request 18912 was acted upon. > >>Transaction: Ticket created by MAKOTO > >> Queue: CGI-Session > >> Subject: Would you add for compatibility? > >> Owner: Nobody > >> Requestors: MAKOTO@cpan.org > >> Status: new > >> Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18912 > > >> > >> > >>Session.pm > >>267a268,277 > >>

> >>>if( @_ == 2){ > >>> my($name,$value) = @_; > >>> if ( $name =~ m/^_SESSION_/ ) { > >>> carp "param(): attempt to write to private parameter"; > >>> return undef; > >>> } > >>> $self->_set_status(STATUS_MODIFIED); > >>> return $self->{_DATA}->{ $name } = $value; > >>>}

> > > > > > Thanks for the contribution MAKOTO. > > > > Could you also submit a test a fails with the current version, so I can > > see what the problem is? > > > > Also, you mention "compatibility". Do you know when we broke this > > compatibility? > > > > > >

>

We've decided to make the case where param has only one key-value pair return the value set. The fix is currently in SVN and should be available for the next release (3.14).

Wed Jun 07 17:05:29 2006 Guest - Correspondence added

From:

mleblanc [...] cpan.org

Show quoted text

> We've decided to make the case where param has only one key-value pair > return the value set. The fix is currently in SVN and should be > available for the next release (3.14).

Err, 4.14. Didn't realize what I had typed until I hit send.

Sat Jun 10 20:10:49 2006 MARKSTOS [...] cpan.org - Taken

Sat Jun 10 20:11:52 2006 MARKSTOS [...] cpan.org - Subject changed from 'Would you add for compatibility?' to 'return value on param() call.'

Sat Jun 10 20:12:21 2006 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'