Skip Menu |

This queue is for tickets about the PGP-Mail CPAN distribution.

Report information
The Basics
Id: 18814
Status: open
Priority: 0/
Queue: PGP-Mail

People
Owner: Nobody in particular
Requestors: pawal [...] blipp.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Patch for fingerprints in PGP::Mail
I need to retrieve the fingerprint (VALIDSIG) in PGP::Mail, so I provide the following patch. Would you please consider it for inclusion in the next release of PGP::Mail?
Subject: Mail.pm.patch
*** Mail.pm 2004-01-26 15:46:09.000000000 +0100 --- ../Mail.pm 2006-04-07 17:27:21.000000000 +0200 *************** *** 77,82 **** --- 77,94 ---- return $self->{'keyid'} } + =head2 I<$pgpmail>->B<fingerprint>(); + + Returns the fingerprint of this signature. + + =cut + + sub fingerprint { + my $self=shift; + + return $self->{'fingerprint'} + } + =head2 I<$pgpmail>->B<data>(); Returns the signed data, run through MIME::Parser if necessary. *************** *** 141,146 **** --- 153,159 ---- $self->{status}="unverified"; $self->{keyid}="0x0000000000000000"; + $self->{fingerprint}=undef; $self->{data}=join("",@lines); if(!$self->{PGPTEXT} && !$self->{PGPMIME}) { *************** *** 202,207 **** --- 215,224 ---- $self->{status}="bad"; $self->{keyid}="0x$1"; } + elsif ($line =~ /^\[GNUPG:\] VALIDSIG (\w+) /) { + $self->{status}="good"; + $self->{fingerprint} = $1; + } } }
CC: bug-PGP-Mail [...] rt.cpan.org
Subject: [rt.cpan.org #18814] Re: Patch for fingerprints in PGP::Mail
Date: Mon, 24 Apr 2006 08:30:22 +0100
To: Patrik Wallstrom <pawal [...] blipp.com>
From: Matthew Byng-Maddick <mbm+cpan [...] colondot.net>
On Fri, Apr 07, 2006 at 05:33:19PM +0200, Patrik Wallstrom wrote: Show quoted text
> I need to retrieve the fingerprint (VALIDSIG) in PGP::Mail, so I > provide the following patch for you. Would you please consider it for > inclusion in the next release of PGP::Mail? I may come up with a few > other patches. I have been using my own PGP module not submitted to > CPAN for the last couple of years, and it has proved to be really > stable. I include it as well.
Hi there, having now got back from holiday (most of last week was spent sorting stuff out for it), I should be able to do this. I've not merged your patch in quite the way you wrote it, in the sense that I'm still relying on GOODSIG to set the status to good, but a VALIDSIG line will add in the key fingerprint. I've not had time to do the release bit yet, but I was going to wait to email you when I did that. Cheers MBM -- After having recently seen Minority Report, I've taken to referring to [the Department of Homeland Security] as the Department of Precrime. -- Simon Cozens
CC: bug-PGP-Mail [...] rt.cpan.org
Subject: Re: [rt.cpan.org #18814] Re: Patch for fingerprints in PGP::Mail
Date: Mon, 24 Apr 2006 10:19:23 +0200
To: Matthew Byng-Maddick <mbm+cpan [...] colondot.net>
From: Patrik Wallstrom <pawal [...] blipp.com>
On Mon, 24 Apr 2006, Matthew Byng-Maddick wrote: Show quoted text
> On Fri, Apr 07, 2006 at 05:33:19PM +0200, Patrik Wallstrom wrote:
> > I need to retrieve the fingerprint (VALIDSIG) in PGP::Mail, so I > > provide the following patch for you. Would you please consider it for > > inclusion in the next release of PGP::Mail? I may come up with a few > > other patches. I have been using my own PGP module not submitted to > > CPAN for the last couple of years, and it has proved to be really > > stable. I include it as well.
> > Hi there, having now got back from holiday (most of last week was spent > sorting stuff out for it), I should be able to do this. I've not merged > your patch in quite the way you wrote it, in the sense that I'm still > relying on GOODSIG to set the status to good, but a VALIDSIG line will > add in the key fingerprint. > > I've not had time to do the release bit yet, but I was going to wait to email > you when I did that.
Thank you! Unfortunately I get an internal server error on rt.cpan.org when trying to display the ticket, but I trust your changes to be ok. -- patrik_wallstrom->foodfight->pawal@blipp.com->+46-733173956
From: pawal [...] blipp.com
Is anything happening with this ticket?