Bug #18792 for Apache-Admin-Config: Directives with a value of '0' are changed to an empty string (breaking the configuration) in dump

Wed Apr 19 20:26:56 2006 dmuey [...] cpan.org - Ticket created

sub write_reformat { ... $string .= $self->$method($name||'', $_->value||''); ... makes directives that have a value of '0' break since the ||'' makes it's value '' instead of '0' now. For example: MaxRequestPerChild 0 will become MaxRequestPerChild and break the configuration. This will fix it: - $string .= $self->$method($name||'', $_->value||''); + my $value = defined $_->value ? : $_->value : ''; + $string .= $self->$method($name||'', $value); Hopefully that can be implemented very very soon :) PS - probably need to check for other places that sort of logic will make an invalid config... Thanks!

Wed Apr 19 20:29:05 2006 dmuey [...] cpan.org - Subject changed from (no value) to 'Directives with a value of '0' are changed to an empty string (breaking the configuration) in dump_rewrite()'

Thu Apr 20 12:39:38 2006 dmuey [...] cpan.org - Correspondence added

Hello, Show quoted text

> + my $value = defined $_->value ? : $_->value : '';

Sorry I was in a hurry, that should have been my $value = defined $_->value ? $_->value : ''; Attached is a fixed version 0.93, please upload to it via your pause account ASAP so these scripts stop making broken configs :) Thanks! - Dan Muey

Download Apache-Admin-Config-0.93.tar.gz
application/x-gzip 27.7k

Message body not shown because it is not plain text.

Tue Apr 25 11:31:40 2006 Guest - Correspondence added

Please upload the new version ASAP, all you have to do is log into pause and upload it. It will take less than 2 minutes, *please* its very very important, thanks :)

Tue Apr 25 11:31:42 2006 The RT System itself - Status changed from 'new' to 'open'

Sun Jun 04 12:20:34 2006 dmuey [...] cpan.org - Correspondence added

I was able to upload 0.93 as co-maintainer. However its under my account and not Oliviaer's which apparently makes CPAN.pm not see it and its still gets 0.92. Attached is 0.94 which is identical to 0.93 except its verison is incremented so that Olivier can upload it to his account via pause.

Download Apache-Admin-Config-0.94.tar.gz
application/x-gzip 27.8k

Message body not shown because it is not plain text.

Sun Jun 04 16:02:33 2006 Guest - Correspondence added

0.94 is up, danke Olivier

Sun Jun 04 16:14:19 2006 rs-pause [...] rhapsodyk.net - Status changed from 'open' to 'resolved'

Tue Jun 06 21:07:49 2006 dmuey [...] cpan.org - Fixed in 0.93 added

Tue Jun 06 21:07:49 2006 dmuey [...] cpan.org - Fixed in 0.94 added

Bug #18792 for Apache-Admin-Config: Directives with a value of '0' are changed to an empty string (breaking the configuration) in dump_rewrite()