On Sat Oct 14 17:45:02 2006, ABH wrote:
Show quoted text> On Mon Apr 17 11:34:12 2006, guest wrote:
> > 7:use vars qw($VERSION $AUTOLOAD @ISA $modules $AUTO_ADD);
> > ^^^^^^^^ --------
> > 369:my $modules = {
> > ^^ --------
> >
> > The "my" on line 369 is not needed. It will destroy any value set
> > with the package variable $XML::RSS:modules (line 7).
>
> Using XML::RSS::modules doesn't seem correct anyway though. Or at
> least there should be a
> proper API for setting it "per object" instead of just as a global
for
Show quoted text> all XML::RSS instances.
There is one - add_module. Only at the moment it sets it globally
because the object's ->{modules} points to the common variable. The
attached patch fixes this and makes sure XML::RSS has one independent
modules reference per object. It also fixes issue
http://rt.cpan.org/Ticket/Display.html?id=19417, because I'm sharing a
working copy with it. Now I'll switch to using svk, so hopefully there
will now be one patch per issue.
Regards,
Shlomi Fish
Show quoted text>
> Any chance you'd make a patch - with tests. :-)
