Bug #18658 for WWW-Mediawiki-Client: mvs doubles newlines

Tue Apr 11 11:56:07 2006 Guest - Ticket created

Subject:

mvs doubles newlines

Files downloaded by "mvs update" have all of their newlines doubled. That is, a file that looks like this on the server: --- line1 line2 line3 --- contains this when downloaded: --- line1 line2 line3 --- Looking at the files with a binary editor shows that the duplicate newlines are newlines; that is "\n\n", not "\r\n" or anything else. Uploading it with mvs commit does not undo this corruption, but deleting the extra lines and uploading works fine. I've tested this on en.wikipedia.org and empegwiki.org with the same results. This is perl, v5.8.6 built for i386-openbsd-3.8.

Tue May 23 18:46:15 2006 Guest - Correspondence added

On Tue Apr 11 11:56:07 2006, guest wrote: Show quoted text

> Files downloaded by "mvs update" have all of their newlines doubled.

I noticed this too. The fix is to replace the "\n" with "" in line 1405. I attach a patch.

--- /root/.cpan/build/WWW-Mediawiki-Client-0.28/lib/WWW/Mediawiki/Client.pm 2005-11-18 17:16:02.000000000 +0000 +++ /usr/local/share/perl/5.8.7/WWW/Mediawiki/Client.pm 2006-05-23 23:42:29.000000000 +0100 @@ -1402,7 +1402,7 @@ $ref = VCS::Lite->new('ref', "\n", "$ref\n"); $server = VCS::Lite->new('server', "\n", "$server\n"); $local = VCS::Lite->new('local', "\n", "$local\n"); - return scalar $ref->merge($server, $local)->text("\n"); + return scalar $ref->merge($server, $local)->text(""); } sub _get_wiki_text {

Tue May 23 18:46:19 2006 The RT System itself - Status changed from 'new' to 'open'

Wed May 24 02:57:55 2006 Guest - Correspondence added

Thanks, both of you for spotting this. I guess I need to do this today or tomorrow. Sorry for being slow. My excuse is that we're having a really weird time at work right now: http://www.who.int/en/ -mark

Fri Jun 30 05:00:52 2006 markj [...] cpan.org - Correspondence added

thanks again. The new version fixes this. --mark

Fri Jun 30 05:00:53 2006 markj [...] cpan.org - Status changed from 'open' to 'resolved'