Skip Menu |

This queue is for tickets about the POE CPAN distribution.

Report information
The Basics
Id: 18646
Status: resolved
Priority: 0/
Queue: POE
People
Owner: Nobody in particular
Requestors: rdb [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.34
Fixed in: (no value)

History Show all quoted text
  Mon Apr 10 20:31:31 2006 Guest - Ticket created
Subject: POE::Kernel::alias_resolve() throws a fatal error under ASSERT_RETVALS
Under POE_ASSERT_DEFAULT=1, (and as it turns out, under ASSERT_RETVALS), if $kernel->alias_resolve() does *not* resolve to a session, it throws a fatal exception, instead of simply warning. This patch fixes it in 0.3401
Subject: alias_resolve_fatal.patch
--- Kernel.pm~ 2006-04-10 15:54:57.000000000 -0700 +++ Kernel.pm 2006-04-10 17:02:36.000000000 -0700 @@ -623,8 +623,8 @@ } $! = ESRCH; - TRACE_RETVALS and _carp "<rv> session not resolved: $!"; - ASSERT_RETVALS and _confess "<rv> session not resolved: $!"; + TRACE_RETVALS and _carp "<rv> session not resolved: $!"; + ASSERT_RETVALS and _carp "<rv> session not resolved: $!"; } ### Explain why a function is returning unsuccessfully.
  Mon Apr 10 20:34:24 2006 Guest - Correspondence added
From: rdb [...] cpan.org
On Mon Apr 10 20:31:31 2006, guest wrote: Show quoted text
> Under POE_ASSERT_DEFAULT=1, (and as it turns out, under ASSERT_RETVALS), > if $kernel->alias_resolve() does *not* resolve to a session, it throws a > fatal exception, instead of simply warning. > > This patch fixes it in 0.3401
Now that I think about it, is that warning even needed under ASSERT?
  Mon Apr 10 20:34:24 2006 The RT System itself - Status changed from 'new' to 'open'
  Thu Aug 31 23:54:31 2006 RCAPUTO [...] cpan.org - Correspondence added
You're right. alias_resolve() should not throw errors or traces if an alias fails to resolve. The asserts and traces have been removed. Thanks for the bug report and patch.
  Thu Aug 31 23:54:32 2006 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Sep 12 22:06:53 2006 rdb [...] cpan.org - Status changed from 'resolved' to 'open'
  Sat Sep 16 02:19:16 2006 RCAPUTO [...] cpan.org - Correspondence added
Re-resolving it. RDB reopened it without a note.
  Sat Sep 16 02:19:18 2006 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Sep 18 14:39:17 2006 RCAPUTO [...] cpan.org - Status changed from 'resolved' to 'open'
  Mon Sep 18 14:39:58 2006 RCAPUTO [...] cpan.org - Correspondence added
On Sat Sep 16 02:19:16 2006, RCAPUTO wrote: Show quoted text
> Re-resolving it. RDB reopened it without a note.
He actually reopened it because his patch was never applied.
  Mon Sep 18 15:32:48 2006 APOCAL [...] cpan.org - Correspondence added
Should be fixed in POE-0.38 -- ~Apocalypse
  Mon Sep 18 15:32:51 2006 APOCAL [...] cpan.org - Status changed from 'open' to 'resolved'