| Subject: | get_all_ENCODING() returns list of array-references |
Hi,
Great functionality! Found this module instrumental for working with bdf
files.
Thanks for that!
I noted one problem dough. For my application, I needed the individual
chars in numerical order, based of their 'ENCODING' value.
get_all_ENCODING() seemed the perfect method, but it failed to retun a
list of 'ENCODING' values, returning a list of array-references instead.
(get_all_STARTCHAR() does work as expected.)
Changing Reader.pm, line 191 from :
if( $key eq "STARTCHAR" or $val eq "ENCODING" ) {
to :
if( $key eq "STARTCHAR" or $key eq "ENCODING" ) {
fixed this for me.
In the sideline. A numerical sort "sort {$a <=> $b}" seems more
appropreate for this method. But that implies a change in the
specification. Do not know what your feeling is about that. Personally,
I think this change acceptable, given current behavior probably implies
the method was not used yet.
Again, thanks for the great work!
Regards,
Hans Pype