Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 18423
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: thaljef [...] cpan.org
Requestors: dankeen [...] mac.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: VERSION check does not notice Readonly::Scalar version
It's broken in 0.15, but that's not an option above. Basically, doing something like: Readonly::Scalar our ($VERSION) => '$Revision: 1.21.12.9 $' =~ m{ \$Revision: \s+ (\S+) }x; Fails two checks - one is that the VERSION checker doesn't know that Readonly::Scalar is ignorable. The second is that $Revision$ doesn't need to be interpolated, but that's ignored by ## no critic - but $VERSION isn't something that can just be skipped. However, this doesn't look like a simple fix. It would appear that PPI::Statement::Variable is not matching the above.
This has been fixed in Perl-Critic-1.04 which has just been uploaded to CPAN. Thanks for reporting this! -Jeff