| Subject: | Patch for CDDB 1.16 |
| Date: | Sat, 26 Nov 2005 22:54:06 +0100 |
| To: | rcaputo [...] cpan.org |
| From: | Jasper Lievisse Adriaanse <jasper [...] nedbsd.nl> |
Hello,
I have just updated the CDDB port for OpenBSD to version 1.16. But while
doing this I noticed a bug/error in t/cddb.t. Steven Mestdagh
(steven@openbsd.org) fixed this bug by writing the following patch:
--- t/cddb.t.orig Sat Nov 26 20:19:34 2005
+++ t/cddb.t Sat Nov 26 20:55:04 2005
@@ -134,13 +134,13 @@ else {
print "not ok 12\n";
}
-### test looking up discs (one match)
+### test looking up discs (two matches)
my @discs = $cddb->get_discs($id, $track_offsets, $total_seconds);
-(@discs == 1) || print 'not '; print "ok 13\n";
+(@discs == 2) || print 'not '; print "ok 13\n";
-my ($genre, $cddb_id, $title) = @{$discs[0]};
+my ($genre, $cddb_id, $title) = @{$discs[1]};
($genre eq 'misc') || print 'not '; print "ok 14\n";
($cddb_id eq '03015501') || print 'not '; print "ok 15\n";
@@ -153,7 +153,7 @@ $cddb->disconnect();
my @other_discs = $cddb->get_discs_by_toc(@toc);
if (@other_discs) {
- (@other_discs == 1) || print 'not '; print "ok 17\n";
+ (@other_discs == 2) || print 'not '; print "ok 17\n";
($other_discs[0]->[0] eq $discs[0]->[0]) || print 'not '; print
"ok 18\n";
($other_discs[0]->[1] eq $discs[0]->[1]) || print 'not '; print
"ok 19\n";
($other_discs[0]->[2] eq $discs[0]->[2]) || print 'not '; print
"ok 20\n";
I hope you can use this patch.
Cheers,
Jasper (maintainer of devel/p5-cddb)
--
"Security is decided by quality" -- Theo de Raadt