Bug #18239 for Crypt-OpenSSL-RSA: missing includes to build

Sun Mar 19 04:57:39 2006 Guest - Ticket created

Subject:

missing includes to build

While trying to build Crypt-OpenSSL-RSA-0.22 from source on a Debian/unstable system, I encountered the 2 following compilation errors : 1. RSA.xs:67: erreur: 'MD5_DIGEST_LENGTH' undeclared (first use in this function) 2. RSA.xs:73: erreur: 'RIPEMD160_DIGEST_LENGTH' undeclared (first use in this function) I had to add the 2 following includes at the top of the RSA.c source file : #include <openssl/md5.h> #include <openssl/ripemd.h> Evreything went right after this 2€cts patch Hth,

Sun Apr 02 21:42:18 2006 Guest - Correspondence added

From:

Sidney Markowitz <sidney [...] sidney.com>

I'm seeinng the same error trying to build in Fedora Core 5 with openssl and openssl-devel RPMs installed, version 0.9.8a. On Sun Mar 19 04:57:39 2006, guest wrote: Show quoted text

> I had to add the 2 following includes at the top of the RSA.c source > file : > > #include <openssl/md5.h> > #include <openssl/ripemd.h>

They ought to be added in RSA.xs, as RSA.c is generated from that. I think you should also add #include <openssl/sha.h> because that is only included because RSA.xs includes ssl.h which includes x509.h which includes sha.h. I'm guessing that there was some similar indirect include of md5.h and ripemd.h in erasrlier versions of openssl, but there was no guarantee they would continue to be included like that. The safest thing to protect against future such changes in openSSL is to explicitly include all three files where they are needed, in RSA.xs.

Sun Apr 02 21:42:19 2006 The RT System itself - Status changed from 'new' to 'open'

Sat Apr 08 01:49:58 2006 Guest - Correspondence added

From:

k.heinz-cpan [...] onlinehome.de

On Sun Mar 19 04:57:39 2006, guest wrote: Show quoted text

> #include <openssl/md5.h> > #include <openssl/ripemd.h>

I observed the same thing while updating Crypt::OpenSSL::RSA for the pkgsrc package collection. ciao Klaus Heinz

Download patch-aa
application/octet-stream 289b

Message body not shown because it is not plain text.

Thu Apr 13 09:45:23 2006 Guest - Correspondence added

From:

iroberts [...] cpan.org

This has been fixed in version 0.23, just released. On Sat Apr 08 01:49:58 2006, guest wrote: Show quoted text

> On Sun Mar 19 04:57:39 2006, guest wrote: >

> > #include <openssl/md5.h> > > #include <openssl/ripemd.h>

> > > I observed the same thing while updating Crypt::OpenSSL::RSA for the > pkgsrc package collection. > > ciao > Klaus Heinz

Fri Apr 14 01:53:26 2006 iroberts+perl [...] red-bean.com - Status changed from 'open' to 'resolved'

Fri Apr 14 10:43:31 2006 iroberts+perl [...] red-bean.com - Broken in 0.08 added

Fri Apr 14 10:43:31 2006 iroberts+perl [...] red-bean.com - Broken in 0.09 added

Fri Apr 14 10:43:31 2006 iroberts+perl [...] red-bean.com - Broken in 0.10 added

Fri Apr 14 10:43:31 2006 iroberts+perl [...] red-bean.com - Broken in 0.11 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.12 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.13 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.14 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.15 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.16 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.17 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.18 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.19 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.20 added

Fri Apr 14 10:43:32 2006 iroberts+perl [...] red-bean.com - Broken in 0.21 added

Fri Apr 14 10:43:33 2006 iroberts+perl [...] red-bean.com - Fixed in 0.23 added

Fri Apr 14 10:43:33 2006 iroberts+perl [...] red-bean.com - Fixed in 0.22 deleted