Bug #18236 for Data-FormValidator: _arrayify will return an empty array for an emtpy string value

Sat Mar 18 20:08:53 2006 Guest - Ticket created

Subject:

_arrayify will return an empty array for an emtpy string value

The following line occurs in Class::DBI::FromForm: $them->$col( $results->valid($col)); If the value of the column is '', which will occur when the column needs to be cleared, then, because the result should be in an array context, valid will return () in stead of the expected ( '' ). Not sure if this is working as intended or a bug. I changed _arrayify to simply return an ( $val ) if $val isn't an array ref and the problem vanished. Kevin

Mon Mar 20 09:59:55 2006 mark [...] summersault.com - Correspondence added

Subject:	Re: [rt.cpan.org #18236] _arrayify will return an empty array for an emtpy string value
Date:	Mon, 20 Mar 2006 09:59:36 -0500
To:	Guest via RT <bug-Data-FormValidator [...] rt.cpan.org>
From:	Mark Stosberg <mark [...] summersault.com>

On Sat, Mar 18, 2006 at 08:08:53PM -0500, Guest via RT wrote: Show quoted text

> > Sat Mar 18 20:08:53 2006: Request 18236 was acted upon. > Transaction: Ticket created by guest > Queue: Data-FormValidator > Subject: _arrayify will return an empty array for an emtpy string value > Owner: Nobody > Requestors: kevin@theconfused.co.uk > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=18236 > > > > The following line occurs in Class::DBI::FromForm: > > $them->$col( $results->valid($col)); > > If the value of the column is '', which will occur when the column needs > to be cleared, then, because the result should be in an array context, > valid will return () in stead of the expected ( '' ). > > Not sure if this is working as intended or a bug.

Kevn, to clarify this, please create a new test case for the DFV test suite. DFV also have global filters, which would treat '' as blank, and turn it into 'undef'. Your test will clarify the behavior. Also, cross reference to the docs for valid() to see if there is documentation for this case and if it is consistent. Mark

Mon Mar 20 09:59:56 2006 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 12 20:16:30 2006 MARKSTOS [...] cpan.org - Taken

Mon Jun 12 20:17:14 2006 MARKSTOS [...] cpan.org - Status changed from 'open' to 'stalled'

Mon Jun 12 20:17:15 2006 MARKSTOS [...] cpan.org - Severity Important changed to Normal

Wed Mar 07 10:40:30 2007 MARKSTOS [...] cpan.org - Correspondence added

From:

MARKSTOS [...] cpan.org

On Sat Mar 18 20:08:53 2006, guest wrote: Show quoted text

> The following line occurs in Class::DBI::FromForm: > > $them->$col( $results->valid($col)); > > If the value of the column is '', which will occur when the column needs > to be cleared, then, because the result should be in an array context, > valid will return () in stead of the expected ( '' ). > > Not sure if this is working as intended or a bug. > > I changed _arrayify to simply return an ( $val ) if $val isn't an array > ref and the problem vanished.

I'm closing this bug as "WONTFIX" for now. I think it's reasonable that '' gets translated to into an empty list or undef. Even for the "use case" you supply, it's reasonable to use 'undef' rather than '' to clear out a field. Perhaps you are getting bitten by list context versus scalar context? Try this with the original code: $them->$col( scalar $results->valid($col)); My guess is that might return "undef" rather than an empty list and possibly solve your problem. I think the current behavior is reasonable and likely bring /other/ software change it. If you feel strongly the change should be made, petition the DFV users list and get some other opinions on the issue. Mark

Wed Mar 07 10:40:31 2007 The RT System itself - Status changed from 'stalled' to 'open'

Wed Mar 07 10:40:56 2007 MARKSTOS [...] cpan.org - Status changed from 'open' to 'rejected'

Bug #18236 for Data-FormValidator: _arrayify will return an empty array for an emtpy string value

Maintainer(s)' notes