Bug #18225 for Term-ReadLine-Perl: non-compliant implementation of MinLine() method

Fri Mar 17 16:50:49 2006 Guest - Ticket created

Subject:

non-compliant implementation of MinLine() method

Hi Ilya, this issue was already forwarded to you years ago by Joerg Jaspert. I'm filing a report here as well, in case it's been forgotten, as it's still present in 1.0208 :) From the docs included with Term::ReadLine: ""MinLine"" If argument is specified, it is an advice on minimal size of line to be included into his- tory. "undef" means do not include anything into history. Returns the old value. From the code: sub MinLine { shift; $readline::minlength = shift } Clearly, this needs to be more like: sub MinLine { my $rv = $readline::minlength; if(@_ == 2) { $readline::minlength = $_[1] } return $rv; } to comply with the interface definition. Please consider including the fix. [This was originally reported as Debian bug #121176, http://bugs.debian.org/121176 ] Cheers, -- Niko Tyni (on behalf of the Debian Perl Group) ntyni@iki.fi

Fri Mar 17 19:30:14 2006 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #18225] non-compliant implementation of MinLine() method
Date:	Fri, 17 Mar 2006 16:29:00 -0800
To:	Guest via RT <bug-Term-ReadLine-Perl [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Fri, Mar 17, 2006 at 04:50:50PM -0500, Guest via RT wrote: Show quoted text

> this issue was already forwarded to you years ago by Joerg Jaspert. I'm > filing a report here as well, in case it's been forgotten, as it's still > present in 1.0208 :)

I think it was lost in transfer (anyway, I do not remember it). Show quoted text

> sub MinLine > { > my $rv = $readline::minlength; > if(@_ == 2) { $readline::minlength = $_[1] } > return $rv; > } > > to comply with the interface definition.

Thanks, >>TODO, Ilya

Fri Mar 17 19:30:14 2006 The RT System itself - Status changed from 'new' to 'open'